Add an extendedIndentForExpressionBodies flag to the WRONG_INDENTATION check
#1443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…TION` check ### What's done: * This commit adds a separate `extendedIndentForExpressionBodies` flag, defaulting to `false`. * The flag controls whether continuation indent is used to indent expression bodies (previously, controlled with `extendedIndentAfterOperators`). * The corresponding flags are: * _IDEA_: `CONTINUATION_INDENT_FOR_EXPRESSION_BODIES` * `.editorconfig`: `ij_kotlin_continuation_indent_for_expression_bodies`
Codecov Report
@@ Coverage Diff @@
## master #1443 +/- ##
=========================================
Coverage 83.23% 83.23%
- Complexity 2560 2562 +2
=========================================
Files 107 107
Lines 7618 7619 +1
Branches 2103 2103
=========================================
+ Hits 6341 6342 +1
Misses 388 388
Partials 889 889
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
### What's done: * `appendix.tex` changed.
petertrr
approved these changes
Jul 13, 2022
0x6675636b796f75676974687562
deleted the
bugfix/andrey.shcheglov/indentation
branch
1 task
0x6675636b796f75676974687562
added a commit
that referenced
this pull request
Jul 13, 2022
### What's done: * Once we now have a separate flag for assignment (`extendedIndentForExpressionBodies`, `false` by default, see #1443), let's set `extendedIndentAfterOperators` back to `true` to be consistent with how IDEA formats Kotlin source files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done:
extendedIndentForExpressionBodiesflag,defaulting to
false.bodies (previously, controlled with
extendedIndentAfterOperators).CONTINUATION_INDENT_FOR_EXPRESSION_BODIES.editorconfig:ij_kotlin_continuation_indent_for_expression_bodiesWhich rule and warnings did you add?
WRONG_INDENTATIONextendedIndentForExpressionBodiesActions checklist