Bugfixing of single binary expression wrapped in parentheses (long lines rule) #1416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Correct logic - if solo `binary expression` contained in `parentheses` * Added 1 fix test ## Issue (#1415)
Codecov Report
@@ Coverage Diff @@
## master #1416 +/- ##
============================================
- Coverage 83.39% 83.37% -0.02%
Complexity 2561 2561
============================================
Files 107 107
Lines 7601 7604 +3
Branches 2097 2100 +3
============================================
+ Hits 6339 6340 +1
Misses 374 374
- Partials 888 890 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Arrgentum
changed the title
binary expression contained in parenthesesbinary exprssion contained in parentheses
orchestr7
reviewed
Jun 30, 2022
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/chapter3/LineLength.kt
Show resolved
Hide resolved
orchestr7
approved these changes
Jun 30, 2022
orchestr7
changed the title
binary exprssion contained in parentheses
nulls
reviewed
Jul 1, 2022
| @@ -107,4 +107,9 @@ class LineLengthFixTest : FixTestBase("test/paragraph3/long_line", ::LineLength) | |||
| fun `fix bin expression first symbol last word`() { | |||
| fixAndCompare("LongBinaryExpressionLastWordExpected.kt", "LongBinaryExpressionLastWordTest.kt", rulesConfigListErrorLineLength1) | |||
| } | |||
|
|
|||
| @Test | |||
| fun `fix bin 1expression first symbol last word`() { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whats added:
Error in method fix in class Binary Expression - if
binary expressioncontained inparenthesesfind child with typeoperation referencesis nullThis pull request closes #1415
Actions checklist
Any information: