[#1347] Stop using DEFAULT_INDENT_SIZE directly
#1382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What's done: * `DEFAULT_INDENT_SIZE` is no longer used directly, in favor of `IndentationConfig.indentationSize`. * `IndentationConfig.indentationSize` usages encapsulated where possible.
Codecov Report
@@ Coverage Diff @@
## master #1382 +/- ##
============================================
- Coverage 83.53% 83.47% -0.06%
+ Complexity 2552 2550 -2
============================================
Files 106 107 +1
Lines 7517 7547 +30
Branches 2081 2082 +1
============================================
+ Hits 6279 6300 +21
- Misses 359 367 +8
- Partials 879 880 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
petertrr
approved these changes
Jun 21, 2022
0x6675636b796f75676974687562
deleted the
feature/andrey.shcheglov/indentation-unit-tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done:
DEFAULT_INDENT_SIZEis no longer used directly, in favor ofIndentationConfig.indentationSize.IndentationConfig.indentationSizeusages encapsulated where possible.