Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/fix cause long line #1373

Merged
merged 13 commits into from
Jun 21, 2022
Merged

Bugfix/fix cause long line #1373

merged 13 commits into from
Jun 21, 2022

Conversation

Arrgentum
Copy link
Member

When fix multiline expressions(only Operator Referenes), long lines appear

This pull request closes #1339

Actions checklist

  • Add smart split in Operator Reference
  • Added tests on fixers in DiktatSmokeTest - fix can cause long line, ManyLineTransformInLongLineExpected.kt and ManyLineTransformInLongLineTest

Arrgentum added 3 commits June 17, 2022 15:33
 * correct logic check White Space around Operator References in WhiteSpaceRule.kt
 * added smoke test

### Issue(#1339)
 * correct logic check White Space around Operator References in WhiteSpaceRule.kt
 * added smoke test
 * fix all

### Issue(#1339)
 * correct logic check White Space around Operator References in WhiteSpaceRule.kt
 * added smoke test
 * fix all

### Issue(#1339)
@codecov
Copy link

codecov bot commented Jun 17, 2022

Codecov Report

Merging #1373 (e63c838) into master (9288199) will decrease coverage by 0.04%.
The diff coverage is 54.54%.

@@             Coverage Diff              @@
##             master    #1373      +/-   ##
============================================
- Coverage     83.47%   83.43%   -0.05%     
- Complexity     2550     2555       +5     
============================================
  Files           107      107              
  Lines          7547     7557      +10     
  Branches       2082     2087       +5     
============================================
+ Hits           6300     6305       +5     
- Misses          367      368       +1     
- Partials        880      884       +4     
Flag Coverage Δ
unittests 83.43% <54.54%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tat/ruleset/rules/chapter3/files/WhiteSpaceRule.kt 81.15% <54.54%> (-1.59%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9288199...e63c838. Read the comment docs.

Arrgentum and others added 2 commits June 17, 2022 16:11
 * correct logic check White Space around Operator References in WhiteSpaceRule.kt
 * added smoke test
 * fix all

### Issue(#1339)
Arrgentum added 2 commits June 17, 2022 16:23
 * correct logic check White Space around Operator References in WhiteSpaceRule.kt
 * added smoke test
 * fix all

### Issue(#1339)
 * correct logic check White Space around Operator References in WhiteSpaceRule.kt
 * added smoke test
 * fix all

### Issue(#1339)
Arrgentum added 2 commits June 17, 2022 16:30
 * correct logic check White Space around Operator References in WhiteSpaceRule.kt
 * added smoke test
 * fix all

### Issue(#1339)
 * correct logic check White Space around Operator References in WhiteSpaceRule.kt
 * added smoke test
 * fix all

### Issue(#1339)
@github-actions
Copy link
Contributor

github-actions bot commented Jun 17, 2022

JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v1)

   151 files     151 suites   8m 22s ⏱️
1 261 tests 1 239 ✔️ 20 💤 2
1 263 runs  1 241 ✔️ 20 💤 2

For more details on these failures, see this check.

Results for commit e63c838.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 17, 2022

JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v1)

1 261 tests   1 241 ✔️  8m 40s ⏱️
   151 suites       20 💤
   151 files           0

Results for commit e63c838.

♻️ This comment has been updated with latest results.

Arrgentum and others added 3 commits June 21, 2022 11:37
 * correct logic check White Space around Operator References in WhiteSpaceRule.kt
 * added smoke test
 * fix all

### Issue(#1339)
 * correct logic check White Space around Operator References in WhiteSpaceRule.kt
 * added smoke test
 * fix all

### Issue(#1339)
@Arrgentum Arrgentum mentioned this pull request Jun 21, 2022
@Arrgentum Arrgentum requested a review from nulls June 21, 2022 09:42
Copy link
Member

@nulls nulls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@Arrgentum Arrgentum enabled auto-merge (squash) June 21, 2022 12:16
@Arrgentum Arrgentum merged commit 9e12cdf into master Jun 21, 2022
@Arrgentum Arrgentum deleted the bugfix/fix_cause_long_line branch June 21, 2022 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NEWLINES_RULES: fix can cause long lines
2 participants