Gradle and Maven Plugins: reporter types are fixed and updated #1180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What's done: - Fixing gradle plugin reporter to support Sarif
orchestr7
force-pushed
the
bugfix/reporter-fixing-gradle
branch
2 times, most recently
from
d2dd1fa to
5c78bab
Compare
orchestr7
force-pushed
the
bugfix/reporter-fixing-gradle
branch
from
5c78bab to
2b76e86
Compare
orchestr7
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1180 +/- ##
============================================
- Coverage 84.64% 84.52% -0.13%
+ Complexity 2519 2515 -4
============================================
Files 103 103
Lines 7055 7055
Branches 1899 1902 +3
============================================
- Hits 5972 5963 -9
- Misses 302 306 +4
- Partials 781 786 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
petertrr
reviewed
Jan 24, 2022
| private fun setReporterType(diktatExtension: DiktatExtension, flag: java.lang.StringBuilder) { | ||
| val name = diktatExtension.reporterType | ||
| val validReporterTypes = listOf("sarif", "plain", "json", "html") | ||
| if (name.isEmpty() || !validReporterTypes.contains(name.trim())) { |
There was a problem hiding this comment.
What about custom reporters here?
There was a problem hiding this comment.
I thought we talked about that, no? I think that we should not give people any liberty and a chance to use their own formats. We are already fucked up with with custom formats. It's time to stop it. SARIF - is the solution
…ktat-static-analysis/diKTat into bugfix/reporter-fixing-gradle
Co-authored-by: Peter Trifanov <[email protected]>
orchestr7
commented
Jan 25, 2022
diktat-gradle-plugin/src/main/kotlin/org/cqfn/diktat/plugin/gradle/DiktatJavaExecTaskBase.kt
Show resolved
Hide resolved
petertrr
approved these changes
Jan 26, 2022
…nto bugfix/reporter-fixing-gradle
orchestr7
changed the title
orchestr7
changed the title
petertrr
approved these changes
Jan 26, 2022
…bugfix/reporter-fixing-gradle
…alysis-dev/diktat into bugfix/reporter-fixing-gradle
…ktat-static-analysis/diKTat into bugfix/reporter-fixing-gradle
### What's done: - Fixing diktat issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done:
This pull request partially closes #1179