Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate code-formating problem #865

Closed
kentr0w opened this issue Apr 30, 2021 · 2 comments · Fixed by #1337
Closed

Investigate code-formating problem #865

kentr0w opened this issue Apr 30, 2021 · 2 comments · Fixed by #1337
Assignees
@Arrgentum
Labels
autofix Issues related to diktat in autofix mode bug Something isn't working good first issue Good for newcomers
Milestone
1.2.0

Comments

@kentr0w
Copy link
Collaborator

kentr0w commented Apr 30, 2021 •
edited by petertrr
Loading

Invalide code

private fun ASTNode.getBreakNodeFromIf(type: IElementType) = this
        .treeParent
        .findChildByType(type)?.let {
            it.findChildByType(BLOCK) ?: it
        }?.hasChildOfType(BREAK) ?: false

Expected behavior

private fun ASTNode.getBreakNodeFromIf(type: IElementType) = this
        .treeParent
        .findChildByType(type)
        ?.let {
            it.findChildByType(BLOCK) ?: it
        }
        ?.hasChildOfType(BREAK) 
        ?: false

diktat version: 0.5.1
@kentr0w kentr0w added the bug Something isn't working label Apr 30, 2021
@kentr0w kentr0w mentioned this issue Apr 30, 2021
Merged
3 tasks
@petertrr petertrr added the autofix Issues related to diktat in autofix mode label Jul 1, 2021
@petertrr petertrr added this to the 1.0.0 milestone Aug 9, 2021
@petertrr
Copy link
Member

petertrr commented Aug 9, 2021

Probably something to do with the way we count function calls in chains (we have a threshold, under which we don't fix). I suppose, we should allow only single-line calls under the threshold.

@petertrr petertrr modified the milestones: 1.0.0, 1.1.0 Dec 12, 2021
@orchestr7 orchestr7 modified the milestones: 1.1.0, 1.1.1 Apr 13, 2022
@orchestr7 orchestr7 added the good first issue Good for newcomers label Apr 27, 2022
Arrgentum pushed a commit that referenced this issue May 25, 2022
### Whats added:
edfac82 
 * corrected logic fix and warn long Dot Qualified Expression

 ### Issue (#865)
Arrgentum pushed a commit that referenced this issue May 25, 2022
### Whats added:
e24e06b 
 * corrected logic fix and warn long Dot Qualified Expression and Safe Access Expression

 ### Issue (#865)
Arrgentum pushed a commit that referenced this issue May 25, 2022
### Whats added:
678a95b 
 * corrected logic fix and warn long Dot Qualified Expression and Safe Access Expression

 ### Issue (#865)
Arrgentum pushed a commit that referenced this issue May 25, 2022
### Whats added:
56bef60 
 * corrected logic fix and warn long Dot Qualified Expression and Safe Access Expression

 ### Issue (#865)
Arrgentum pushed a commit that referenced this issue May 26, 2022
### Whats added:
e70e1e8 
 * corrected logic fix and warn long Dot Qualified Expression and Safe Access Expression and Postfix Expression

 ### Issue (#865)
Arrgentum pushed a commit that referenced this issue May 26, 2022
### Whats added:
89ac89e 
 * corrected logic fix and warn long Dot Qualified Expression and Safe Access Expression and Postfix Expression

 ### Issue (#865)
Arrgentum pushed a commit that referenced this issue May 26, 2022
### Whats added:
cf766f6 
 * corrected NAME_ID

 ### Issue (#865)
Arrgentum pushed a commit that referenced this issue May 26, 2022
### Whats added:
db25fa0 
 * corrected 1 warn test

 ### Issue (#865)
Arrgentum pushed a commit that referenced this issue May 26, 2022
### Whats added:
ea950e8 
 * corrected 1 warn test

 ### Issue (#865)
Arrgentum pushed a commit that referenced this issue May 27, 2022
### Whats added:
7fb1d93 
 rewrite code

 ### Issue (#865)
Arrgentum pushed a commit that referenced this issue May 31, 2022
### Whats added:
8f3ed88 
 * corrected logic fix and warn long Dot Qualified Expression and Safe Access Expression and Postfix Expression
 * added fix test in NewLineRuleFixTest
 * corrected and added warnings in NewLineRuleWarnTest

 ### Issue (#865)
Arrgentum pushed a commit that referenced this issue May 31, 2022
### Whats added:
80d5e21 
 * corrected logic fix and warn long Dot Qualified Expression and Safe Access Expression and Postfix Expression
 * added fix test in NewLineRuleFixTest
 * corrected and added warnings in NewLineRuleWarnTest
 * run diktat:fix@diktat

 ### Issue (#865)
Arrgentum pushed a commit that referenced this issue May 31, 2022
### Whats added:
51c7c47 
 * corrected logic fix and warn long Dot Qualified Expression and Safe Access Expression and Postfix Expression
 * added fix test in NewLineRuleFixTest
 * corrected and added warnings in NewLineRuleWarnTest
 * run diktat:fix@diktat

  ### Issue (#865)
@Arrgentum Arrgentum mentioned this issue May 31, 2022
Merged
4 tasks
Arrgentum pushed a commit that referenced this issue May 31, 2022
### Whats added:
57201a6 
 * corrected logic fix and warn long Dot Qualified Expression and Safe Access Expression and Postfix Expression
 * added fix test in NewLineRuleFixTest
 * corrected and added warnings in NewLineRuleWarnTest
 * run diktat:fix@diktat

  ### Issue (#865)
Arrgentum pushed a commit that referenced this issue Jun 1, 2022
### Whats added:
5507399 
 * corrected logic fix and warn long Dot Qualified Expression and Safe Access Expression and Postfix Expression
 * added fix test in NewLineRuleFixTest
 * corrected and added warnings in NewLineRuleWarnTest
 * run diktat:fix@diktat

  ### Issue (#865)
Arrgentum pushed a commit that referenced this issue Jun 1, 2022
### Whats added:
b4898a8 
 * corrected logic fix and warn long Dot Qualified Expression and Safe Access Expression and Postfix Expression
 * added fix test in NewLineRuleFixTest
 * corrected and added warnings in NewLineRuleWarnTest
 * run diktat:fix@diktat

  ### Issue (#865)
Arrgentum pushed a commit that referenced this issue Jun 1, 2022
Correct warning message
d8fb515 
### Whats added:
 * corrected logic fix and warn long Dot Qualified Expression and Safe Access Expression and Postfix Expression
 * added fix test in NewLineRuleFixTest
 * corrected and added warnings in NewLineRuleWarnTest
 * run diktat:fix@diktat

  ### Issue (#865)
Arrgentum pushed a commit that referenced this issue Jun 1, 2022
Corrected diktats code according to this rule
163fb83 
### Whats added:
 * corrected logic fix and warn long Dot Qualified Expression and Safe Access Expression and Postfix Expression
 * added fix test in NewLineRuleFixTest
 * corrected and added warnings in NewLineRuleWarnTest
 * run diktat:fix@diktat

  ### Issue (#865)
Arrgentum pushed a commit that referenced this issue Jun 1, 2022
Corrected diktats code according to this rule
9192489 
### Whats added:
 * corrected logic fix and warn long Dot Qualified Expression and Safe Access Expression and Postfix Expression
 * added fix test in NewLineRuleFixTest
 * corrected and added warnings in NewLineRuleWarnTest
 * run diktat:fix@diktat

  ### Issue (#865)
Arrgentum pushed a commit that referenced this issue Jun 1, 2022
Corrected diktats code according to this rule
686f2d6 
### Whats added:
 * corrected logic fix and warn long Dot Qualified Expression and Safe Access Expression and Postfix Expression
 * added fix test in NewLineRuleFixTest
 * corrected and added warnings in NewLineRuleWarnTest
 * run diktat:fix@diktat

  ### Issue (#865)
Arrgentum pushed a commit that referenced this issue Jun 1, 2022
Corrected diktats code according to this rule
120d2e4 
### Whats added:
 * corrected logic fix and warn long Dot Qualified Expression and Safe Access Expression and Postfix Expression
 * added fix test in NewLineRuleFixTest
 * corrected and added warnings in NewLineRuleWarnTest
 * run diktat:fix@diktat

  ### Issue (#865)
Arrgentum pushed a commit that referenced this issue Jun 1, 2022
Corrected diktats code according to this rule
279d697 
### Whats added:
 * corrected logic fix and warn long Dot Qualified Expression and Safe Access Expression and Postfix Expression
 * added fix test in NewLineRuleFixTest
 * corrected and added warnings in NewLineRuleWarnTest
 * run diktat:fix@diktat

  ### Issue (#865)
Arrgentum pushed a commit that referenced this issue Jun 3, 2022
Corrected the code according to the review
55c6e2c 
### Whats added:
 * corrected logic fix and warn long Dot Qualified Expression and Safe Access Expression and Postfix Expression
 * added fix test in NewLineRuleFixTest
 * corrected and added warnings in NewLineRuleWarnTest
 * run diktat:fix@diktat

  ### Issue (#865)
Arrgentum pushed a commit that referenced this issue Jun 3, 2022
Corrected the code using check
05c5a44 
### Whats added:
 * corrected logic fix and warn long Dot Qualified Expression and Safe Access Expression and Postfix Expression
 * added fix test in NewLineRuleFixTest
 * corrected and added warnings in NewLineRuleWarnTest
 * run diktat:fix@diktat

  ### Issue (#865)
Arrgentum pushed a commit that referenced this issue Jun 9, 2022
commented logics code
cfbdc7d 
### Whats added:
 * corrected logic fix and warn long Dot Qualified Expression and Safe Access Expression and Postfix Expression
 * commented on the choice of different logics with these expressions
 * added fix test in NewLineRuleFixTest
 * corrected and added warnings in NewLineRuleWarnTest
 * run diktat:fix@diktat

  ### Issue (#865)
Arrgentum pushed a commit that referenced this issue Jun 9, 2022
corrected code with diktat:fix
c2c49c5 
### Whats added:
 * corrected logic fix and warn long Dot Qualified Expression and Safe Access Expression and Postfix Expression
 * commented on the choice of different logics with these expressions
 * added fix test in NewLineRuleFixTest
 * corrected and added warnings in NewLineRuleWarnTest
 * run diktat:fix@diktat

  ### Issue (#865)
Arrgentum pushed a commit that referenced this issue Jun 9, 2022
corrected code with diktat:fix
0a15780 
### Whats added:
 * corrected logic fix and warn long Dot Qualified Expression and Safe Access Expression and Postfix Expression
 * commented on the choice of different logics with these expressions
 * added fix test in NewLineRuleFixTest
 * corrected and added warnings in NewLineRuleWarnTest
 * run diktat:fix@diktat

  ### Issue (#865)
Arrgentum added a commit that referenced this issue Jun 15, 2022
@Arrgentum
Bugfix/new lines rule dot qualified expression and safe access expres…
3dcd13e 
…sion (#1337)

### Whats added:
 * corrected logic fix and warn long Dot Qualified Expression and Safe Access Expression and Postfix Expression
 * commented on the choice of different logics with these expressions
 * added fix test in NewLineRuleFixTest
 * corrected and added warnings in NewLineRuleWarnTest
 
  ### Issue (#865)
@Arrgentum
Copy link
Member

close in #1337 Pull Request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Arrgentum Arrgentum

Labels
autofix Issues related to diktat in autofix mode bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
1.2.0
Development

Successfully merging a pull request may close this issue.

Bugfix/new lines rule dot qualified expression and safe access expression saveourtool/diktat
4 participants
@petertrr @kentr0w @orchestr7 @Arrgentum