Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove tests for diktat as CLI from Github actions #1752

Closed
nulls opened this issue Sep 25, 2023 · 0 comments · Fixed by #1784
Closed

Remove tests for diktat as CLI from Github actions #1752

nulls opened this issue Sep 25, 2023 · 0 comments · Fixed by #1784
Assignees
@nulls
Labels
infrastructure Issues related to building the project, CI/CD, deployments etc. tests Improve testing
Milestone
2.0.0

Comments

@nulls
Copy link
Member

nulls commented Sep 25, 2023

We have Smoke tests which does the same. Better to run it with different matrix instead of an extra step on Github Actions
@nulls nulls added tests Improve testing infrastructure Issues related to building the project, CI/CD, deployments etc. labels Sep 25, 2023
@nulls nulls added this to the 2.0.0 milestone Sep 25, 2023
@nulls nulls self-assigned this Sep 25, 2023
@nulls nulls mentioned this issue Nov 7, 2023
Closed
nulls added a commit that referenced this issue Nov 8, 2023
@nulls
Moved tests with CLI from GitHub actions to JUnit test
f53fc41 
### What's done:
- removed steps from `build_and_test.yml`
- added a new test `DiktatCliTest.kt`

It closes #1752
@nulls nulls mentioned this issue Nov 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nulls nulls

Labels
infrastructure Issues related to building the project, CI/CD, deployments etc. tests Improve testing
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

Moved tests with CLI from GitHub actions to JUnit test saveourtool/diktat
1 participant
@nulls