Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLANK_LINE_BETWEEN_PROPERTIES false positive when an @Annotation of a private property is followed with a single-line comment #1496

Closed
0x6675636b796f75676974687562 opened this issue Aug 9, 2022 · 0 comments · Fixed by #1608
Assignees
Labels
bug Something isn't working
Milestone

Comments

@0x6675636b796f75676974687562
Copy link
Member

Minimal repro:

class C {
    private val val0 = Regex("""\d+""")

    @Suppress("WRONG_NEWLINES")  // Trailing comment
    private val val1 = 42

    @Deprecated("Deprecation message")  // Trailing comment
    private val val2 = ""
}

Environment information

  • diktat version: 1.2.3
@0x6675636b796f75676974687562 0x6675636b796f75676974687562 added the bug Something isn't working label Aug 9, 2022
@0x6675636b796f75676974687562 0x6675636b796f75676974687562 added this to the 1.2.4 milestone Aug 9, 2022
@0x6675636b796f75676974687562 0x6675636b796f75676974687562 removed this from the 1.2.4 milestone Aug 10, 2022
@0x6675636b796f75676974687562 0x6675636b796f75676974687562 added this to the 1.2.5 milestone Nov 9, 2022
Cheshiriks added a commit that referenced this issue Feb 2, 2023
### What's done:
* fixed isFollowedByNewlineCheck

Closes #1496
Cheshiriks added a commit that referenced this issue Feb 3, 2023
### What's done:
* fixed isFollowedByNewlineCheck

Closes #1496
Cheshiriks added a commit that referenced this issue Feb 3, 2023
* BLANK_LINE_BETWEEN_PROPERTIES false positive

### What's done:
* fixed isFollowedByNewlineCheck

Closes #1496
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants