Unsigned integer literal is perhaps incorrectly marked as a MAGIC_NUMBER

[michaelkeeling]

Describe the bug

Unsigned integer literal is perhaps incorrectly marked as a MAGIC_NUMBER

Expected behavior

The rules for unsigned numeric values should be the same as the signed counterparts.

Observed behavior

Unsigned integer literal is incorrectly marked as a MAGIC_NUMBER

[MAGIC_NUMBER] avoid using magic numbers, instead define
constants with clear names describing what the magic number means: 0U (cannot be auto-corrected)

Steps to Reproduce

Assign an unsigned integer to a variable.

// this raises a MAGIC_NUMBER warning
var positiveNumber = 0U

// this does not have a warning
var otherNumber = 0

Environment information

• diktat version: 1.0.1
• build tool (maven/gradle): gradle
• how is diktat run (CLI, plugin, etc.): gradle plugin
• kotlin version: 1.6.10
• operating system: MacOS 12.2.1
• link to a project (if your project is public): N/A

[orchestr7]

Oh, looks like we missed this, we only added workarounds for 0,1,2. Should add the same for u, l.
Before the release you can workaround it with a @Suppress annotation.

@michaelkeeling, thank you for this report, sorry that we missed this issue, because of the current situation :(
Will be fixed in the nearest release!

[petertrr]

Before the release you can workaround it with a @Suppress annotation.

Actually, we already support setting custom numbers allowed by this rule. In diktat.yaml in configuration section of MAGIC_NUMBER rule they can be set as a comma-separated list in ignoreNumbers field:

- name: MAGIC_NUMBER
  enabled: true
  configuration:
    ignoreNumbers: 1,2,0U,1U,2U

But sure, literals for longs and unsigned numbers will be supported out-of-the-box as well.