Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding SauceBindings-enabled Visual tests #37

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

mmerrell
Copy link

I wanted to show some examples of Visual tests with the Sauce Bindings libraries. I still need to work on page sync--sometimes the pages don't load before the screenshot is taken.

Copy link
Collaborator

@FriggaHel FriggaHel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

Only thing that is missing is CI integration.
It will help us to ensure that the example is working as we expect.
Example: https://github.com/saucelabs/visual-examples/blob/main/.github/workflows/test.yml#L71-L84 (you may need to rebase first)

@ebekebe
Copy link
Collaborator

ebekebe commented Sep 26, 2023

I see this more as an example of Sauce Bindings than visual, so I think this should live in a "sauce-bindings-examples" repo.

@wswebcreation
Copy link
Contributor

I see this more as an example of Sauce Bindings than visual, so I think this should live in a "sauce-bindings-examples" repo.

I don't fully agree. The examples are meant to show how to use Sauce Visual with all kind of frameworks. Sauce Bindings is one of them.
@mmerrell , can you also update the docs, I can help if needed, with a new page for the SB integration, explaining how to integrate this into an existing SB framework?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants