Tweak/plugin header updates #196
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
related feature https://app.clickup.com/t/85zrjngmt |
gen4ik-saucal
approved these changes
Mar 28, 2023
gen4ik-saucal
left a comment
gen4ik-saucal
left a comment
There was a problem hiding this comment.
I do not like any actions inside a method call, so my suggestion is to move array_merge(headers) to a separate line. Other than that looks good.
Author
|
Updated @gen4ik-saucal according to your comment! Thank you! |
Author
|
Made one more commit here @gen4ik-saucal, if you could check. |
gen4ik-saucal
approved these changes
Apr 26, 2023
gen4ik-saucal
left a comment
gen4ik-saucal
left a comment
There was a problem hiding this comment.
The codewise looks good. Good to go 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Adds 3 new headers to every Request to the Amazon Pay API.
How to test the changes in this Pull Request:
x-amz-pay-platform-versionset to active WooCommerce's versionx-amz-pay-integrator-versionset to active Amazon Pay for WooCommerce plugin's versionx-amz-pay-integrator-idset to the SP's (Solution Provider) ID.Other information:
Changelog entry