replace dask-xgboost with xgboost #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
skirmer
reviewed
Dec 14, 2020
rikturr
suggested changes
Dec 14, 2020
There was a problem hiding this comment.
Looks great!! Found a couple small typos.
And regarding the start script/images, would it be possible to coordinate the release of images and examples together so that we can avoid the workaround in the start script? I'm afraid users could get confused seeing the longer start script, and they might even remove some of the lines, causing problems when they try to spin up the example resources.
| "cell_type": "markdown", | ||
| "metadata": {}, | ||
| "source": [ | ||
| "`xgboost.dask.predict()` can be used to create predictiosn on a Dask collection using an XGBoost model object. Note that this model object is just a regular XGBoost booster, not a special Dask-specific model object.\n", |
There was a problem hiding this comment.
Suggested change
| "`xgboost.dask.predict()` can be used to create predictiosn on a Dask collection using an XGBoost model object. Note that this model object is just a regular XGBoost booster, not a special Dask-specific model object.\n", | |
| "`xgboost.dask.predict()` can be used to create predictions on a Dask collection using an XGBoost model object. Note that this model object is just a regular XGBoost booster, not a special Dask-specific model object.\n", |
| "cell_type": "markdown", | ||
| "metadata": {}, | ||
| "source": [ | ||
| "`xgboost.dask.predict()` can be used to create predictiosn on a Dask collection using an XGBoost model object. Note that this model object is just a regular XGBoost booster, not a special Dask-specific model object.\n", |
There was a problem hiding this comment.
Suggested change
| "`xgboost.dask.predict()` can be used to create predictiosn on a Dask collection using an XGBoost model object. Note that this model object is just a regular XGBoost booster, not a special Dask-specific model object.\n", | |
| "`xgboost.dask.predict()` can be used to create predictions on a Dask collection using an XGBoost model object. Note that this model object is just a regular XGBoost booster, not a special Dask-specific model object.\n", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that xgboost 1.3.0 is available, I think it's time to remove uses of
dask-xgboostin the example here and replace them withxgboost.dask(the Dask interface built in toxgboost). This is the direction the XGBoost + Dask community is moving (dask/community#104, dask/dask-xgboost#39).This PR proposes replacing
dask-xgboostwithxgboost. I tested these changes on the 2020.11.30 release of Saturn (in an internal environment), using the imagesaturncloud/saturn:2020.11.30.While I'm touching the XGBoost code, this PR also replaces cutting over all of the XGBoost examples to
"tree_method": "hist". We had previously used the slower"tree_method": "approx"becausedask-xgboostrequired pinning to an old XGBoost version that didn't supporthist. Buthistis available in 1.3.0 and can be much faster.Notes for Reviewers
In this PR, I'm proposing adding a
startscript forexamples-cputo deal with old XGBoost versions that are currently installed in the 2020.11.30 images. I'll 've added another PR to update the images (saturncloud/images#127), and then whenever those are rebuilt we can change the image used here and remove that start script. Please let me know what you think about this.