Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix small bug from - B 4.2 texture transform bind preview #570

Open
wants to merge 124 commits into
base: main
Choose a base branch
from

Conversation

tdw46
Copy link

@tdw46 tdw46 commented Sep 17, 2024

No description provided.

saturday06 and others added 25 commits August 1, 2024 15:46
@tdw46 tdw46 changed the title B 4.2 texture transform bind preview Fix small bug from - B 4.2 texture transform bind preview Sep 17, 2024
@tdw46
Copy link
Author

tdw46 commented Sep 17, 2024

I came across a small bug here. You can probably just change this in the source branch on your end. I'll need to investigate how to make sure material previews update between frame changes in rendering in a different branch. That's where this bug came from.

@saturday06
Copy link
Owner

expression.materexpression.materials_to_update is a CollectionProperty(type=PropertyGroup), but it actually needs to be a CollectionProperty(type=Material). However, Material cannot be a CollectionProperty element, so a proxy is required. I solved the problem using that proxy in the main branch.

@saturday06 saturday06 changed the title Fix small bug from - B 4.2 texture transform bind preview fix: Fix small bug from - B 4.2 texture transform bind preview Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants