Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug report: Rim Light Mix Incorrect #512

Open
tdw46 opened this issue Jul 1, 2024 · 5 comments
Open

Bug report: Rim Light Mix Incorrect #512

tdw46 opened this issue Jul 1, 2024 · 5 comments

Comments

@tdw46
Copy link

tdw46 commented Jul 1, 2024

The below two nodes in your rimlight calc produce incorrect results:

image

Muting the resolves the problem.

To Reproduce

  1. Add a rim value to any MToon material.
  2. Export.
  3. Compare result in VRM app to Blender

Expected behavior

I expect a result that matches between blender and VRM app.

Screenshots

image
image

Desktop:

  • OS: Windows 11
  • Blender 3.6
  • Addon Version 2.20.61

Additional context

This problem is made worse when you consider that the addon re-appends the latest material nodes any time it is installed or updated. So if I make a tweak to fix this in the material of the file locally, it will get overridden by the append operation on next launch. Not everyone will know how to go into the source folders and adjust the material there.

@saturday06
Copy link
Owner

The light information is required for the correct mtoon rimlight, but it is currently unavailable.

I would implement the implementation to obtain light information.
#515
However, it takes time.

@tdw46
Copy link
Author

tdw46 commented Jul 5, 2024

This makes sense. Thanks for the link to #515. In the meantime, will you mute or remove those two nodes because they give worse results for lookdev than if they are muted?

@tdw46
Copy link
Author

tdw46 commented Jul 5, 2024

Forward render emulation in a deferred rendering pipeline ~~ wow, that will be impressive if you can do it! I did this with only direct lights in Unreal, which was already difficult. All those other light types will be a lot of work. 頑張って💪🏻

@saturday06
Copy link
Owner

saturday06 commented Jul 7, 2024

Thank you for your help. Those two nodes will be muted in the next version.

I won't mute all the inaccurate nodes, because most of them are currently inaccurate.

@saturday06
Copy link
Owner

The latest version 2.20.64 disables rim lighting mix factor nodes for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants