Skip to content

refactor: remove redundant role #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

87xie
Copy link
Contributor

@87xie 87xie commented Jul 14, 2024

What

The <article> tag already has an implicit role defined by the HTML specification, so we do not need to add an ARIA role attribute.

Reference:

Screenshot

After the change:

image

@satnaing
Copy link
Owner

Thanks again!

@satnaing satnaing merged commit b9266cb into satnaing:main Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants