-
Notifications
You must be signed in to change notification settings - Fork 469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OG Image Reworks #123
OG Image Reworks #123
Conversation
related to: 3e0109c
@satnaing, can you test the OG generation on your setup. Just to be extra sure :) |
Love it. Much simpler now. I've checked special character issues and it all works well. |
It's difficult for a dev to find their own bugs 😅, So no edge cases that i can think of for now. I have tested the following cases:
|
@tanishqmanuja
Relative Path # image is `src/assets/example.png`
ogImage: "../../assets/example.png" Alias Path # image is `src/assets/example.png`
ogImage: "@assets/example.png" Absolute Path # image is `public/example.png`
ogImage: /example.png Everything seems to be okay. |
BTW @tanishqmanuja I'm planning to create a PR for the documentation tomorrow or on Saturday. |
Sure, I would help. Btw generally speaking I do not know for myself if there would be any easy migration path. Case 1 - Template Repo: Case 2 - Forked Repo: Case 3 - A Fresh Start: BTW those are my thoughts, how are you planning to write the migration? |
Yep, agree with you. Mostly For If they don't want to do that, they can store/backup their changes and customizations. Those files and directories would probably be I think these are the only ideal ways to upgrade AstroPaper. |
PR for reworking OG image generation and routing logic