Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small fix for ReadXenium #8298

Closed
wants to merge 3 commits into from
Closed

Conversation

alikhuseynov
Copy link
Contributor

Hi, this is just a quick fix for ReadXenium to always return dataframes when sapply is used.
..see issue #8265
thanks

jsicherman and others added 2 commits January 10, 2024 13:39
fix: don't load unassigned codewords when there are none
@jsicherman
Copy link
Contributor

@AustinHartman any update on this? Would be awesome to get it merged when you've got some cycles. Also about to tag you on another Xenium-related PR

@alikhuseynov
Copy link
Contributor Author

@jsicherman I was thinking, probably it would be better to make reading transcript coords optional, such that users can decide themselves if to load molecules or not. I added add.molecules for readVizgen some time ago. Since those coords are not used at all in any analysis in Seurat, only for visualization.

@jsicherman
Copy link
Contributor

@jsicherman I was thinking, probably it would be better to make reading transcript coords optional, such that users can decide themselves if to load molecules or not. I added add.molecules for readVizgen some time ago. Since those coords are not used at all in any analysis in Seurat, only for visualization.

Added in #8605 :)

@pmarks
Copy link
Contributor

pmarks commented Mar 27, 2024

Hi @dcollins15 and @Gesmira. We have a few PRs to improve Xenium support in flight -- this one and #8605. Austin seems to be offline these days. Who should we ping for help getting these merged?

@rsatija
Copy link
Collaborator

rsatija commented Jul 12, 2024

Sincere apologies for the delay. We've been slow to respond to PRs but are going to prioritize this going forward. We'll get back to you soon but to confirm, @pmarks you are signed off on this request? Is this concordant with the additional Xenium PRs as well?

@dcollins15
Copy link
Contributor

These changes LGTM! Most appreciated @alikhuseynov and @jsicherman 🚀

I'm going to close this PR in favor of merging in these two changes separately - I'll tag y'all when I push up your respective commits

@dcollins15 dcollins15 closed this Jul 22, 2024
This was referenced Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants