-
Notifications
You must be signed in to change notification settings - Fork 928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
small fix for ReadXenium
#8298
small fix for ReadXenium
#8298
Conversation
..see issue satijalab#8265
fix: don't load unassigned codewords when there are none
@AustinHartman any update on this? Would be awesome to get it merged when you've got some cycles. Also about to tag you on another Xenium-related PR |
@jsicherman I was thinking, probably it would be better to make reading transcript coords optional, such that users can decide themselves if to load molecules or not. I added |
Added in #8605 :) |
Hi @dcollins15 and @Gesmira. We have a few PRs to improve Xenium support in flight -- this one and #8605. Austin seems to be offline these days. Who should we ping for help getting these merged? |
Sincere apologies for the delay. We've been slow to respond to PRs but are going to prioritize this going forward. We'll get back to you soon but to confirm, @pmarks you are signed off on this request? Is this concordant with the additional Xenium PRs as well? |
These changes LGTM! Most appreciated @alikhuseynov and @jsicherman 🚀 I'm going to close this PR in favor of merging in these two changes separately - I'll tag y'all when I push up your respective commits |
Hi, this is just a quick fix for
ReadXenium
to always return dataframes whensapply
is used...see issue #8265
thanks