enable PCA on data
to exploit sparseness
#2333
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
slot
parameter toRunPCA.Seurat
andRunPCA.Assay
RunPCA
on raw (counts
) or normalized data (data
) without runningScaleData
firstscale
andcenter
parameters to simplify use of implicit scaling/centering inRunPCA
weight.by.var
forapprox=FALSE
#2330 - which should be merged firstcenter
,scale
andslot
parameter values be saved in thedimReduce
object? Where?ScaleData
scale
andcenter
might be better namesdo.scale
anddo.center
,scale
andscale.
andcenter
parameters values should the be used as default if supplied, to keep existing code using these (through ....) functionalapprox=FALSE
only, RunPCA has by default performed centering, while this is only a problem if the user useddo.center=FALSE
inScaleData
, it is inconsistent and should be changedirlba
toprcmp_irlba
if simplify and and optimize prcomp_irlba bwlewis/irlba#52 gets merged