Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flake8 + test fixes #20

Merged
merged 4 commits into from
Apr 9, 2018
Merged

flake8 + test fixes #20

merged 4 commits into from
Apr 9, 2018

Conversation

AmitAronovitch
Copy link
Contributor

@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.875% when pulling f9696e7 on AmitAronovitch:fixes into 44084b8 on satellogic:master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.875% when pulling f9696e7 on AmitAronovitch:fixes into 44084b8 on satellogic:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.875% when pulling f9696e7 on AmitAronovitch:fixes into 44084b8 on satellogic:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.875% when pulling f9696e7 on AmitAronovitch:fixes into 44084b8 on satellogic:master.

@coveralls
Copy link

coveralls commented Mar 31, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 96.875% when pulling 5aa3b03 on AmitAronovitch:fixes into ffa3fdf on satellogic:master.

@AmitAronovitch AmitAronovitch mentioned this pull request Mar 31, 2018
Closed
matiasg
matiasg reviewed Apr 4, 2018
View reviewed changes
tests/test_quaternion.py
@@ -147,7 +147,7 @@ def test_from_ra_dec_roll(self, arr):
[s1 * s3 - c1 * c3 * s2, c3 * s1 + c1 * s2 * s3, c1 * c2] # noqa
]))

assert Quaternion.from_ra_dec_roll(*arr) == Quaternion.from_matrix(expected)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to explicitly add the @example you wrote in the issue, as this will clarify why we need this tolerance.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

matiasg
matiasg requested changes Apr 4, 2018
View reviewed changes
Copy link
Collaborator

@matiasg matiasg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok; I just asked for the problematic example to explicitly show up in the test.

@matiasg matiasg merged commit a2e74cf into satellogic:master Apr 9, 2018
@AmitAronovitch AmitAronovitch deleted the fixes branch April 10, 2018 08:35
matiasg added a commit that referenced this pull request Jul 27, 2020
@matiasg
# This is a combination of 24 commits.
e4fada6 
# This is the 1st commit message:

pin coveralls version

# This is the commit message #2:

rever change of pytest-coverage. Pin python-coverage

# This is the commit message #3:

just as a test, remove coveralls

# This is the commit message #4:

remove also cov from script 🤦

# This is the commit message #5:

pin pytest version

# This is the commit message #6:

pin hypothesis version

# This is the commit message #7:

pin hypothesis to 3.55.1 now

# This is the commit message #8:

do not install pytest-coverage

# This is the commit message #9:

pin pytest-coverage

# This is the commit message #10:

install pinned coverage, do not install pytest-coverage :'(

# This is the commit message #11:

pin attr

# This is the commit message #12:

attr is attrs

# This is the commit message #13:

travis, please tell me attr version

# This is the commit message #14:

go back to original setup.py

# This is the commit message #15:

exclude coveralls from 3.4 & 3.5. Try 1

# This is the commit message #16:

use [] instead of test

# This is the commit message #17:

install pytest 5.4.3

# This is the commit message #18:

travis tell me something

# This is the commit message #19:

please do tell

# This is the commit message #20:

ooohhh?

# This is the commit message #21:

oh 2

# This is the commit message #22:

oh 3

# This is the commit message #23:

oh 4

# This is the commit message #24:

oh 5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matiasg matiasg matiasg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test_from_ra_dec_roll: test failure due to tolerance
3 participants
@AmitAronovitch @coveralls @matiasg