[Indented syntax improvements] Specs #2041
Conversation
…d-syntax-improvements
…d-syntax-improvements
There was a problem hiding this comment.
Since these are testing newlines, not just any whitespace, something in the test names should reflect that.
| /* foo | ||
| * bar */ |
There was a problem hiding this comment.
Is this change correct, or was there a CR in the original that doesn't render properly on GitHub?
|
|
||
| <===> | ||
| ================================================================================ | ||
| <===> loud/multi_line/sass/input.sass |
There was a problem hiding this comment.
Error tests should generally be the last thing in an HRX file.
|
|
||
| <===> | ||
| ================================================================================ | ||
| <===> multiline-list/paren/sass/input.sass |
There was a problem hiding this comment.
|
|
||
| <===> | ||
| ================================================================================ | ||
| <===> multiline-list/paren/sass/input.sass |
There was a problem hiding this comment.
Since there's no reason to test multiline lists for SCSS at all, I'd put them under an indented syntax directory instead of vice versa.
There was a problem hiding this comment.
I don't think you need to test whitespace separately for each separate operator type. All binary operators are parsed essentially the same.
There was a problem hiding this comment.
I don't think you need to test this separately for every place an interpolation can appear.
| @@ -48,6 +48,27 @@ b { | |||
| c: d; | |||
| } | |||
|
|
|||
| <===> | |||
| ================================================================================ | |||
| <===> multiline-no-comma/input.sass | |||
There was a problem hiding this comment.
This should probably go under whitespace/.
There was a problem hiding this comment.
What about cases like a\n, b and a +\nb?
There was a problem hiding this comment.
Aren't these redundant with the tests you have in individual statement directories?
Blocked until proposal is accepted.
[skip dart-sass]
[skip sass-embedded]