-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Ensure am11/pangyp not fetched via SSH #931
Conversation
Before building, first apply the following patch to pangyp: rvagg/archived-pangyp#5 (until it is merged). Issue URL: #870.
@@ -57,7 +57,7 @@ | |||
"mkdirp": "^0.5.0", | |||
"nan": "^1.8.4", | |||
"npmconf": "^2.1.1", | |||
"pangyp": "am11/pangyp", | |||
"pangyp": "git://github.com/am11/pangyp.git#f13599f5198b853948429062c2b334010a337342", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we not just default to the https endpoint to avoid any ssh issues?
I have this problem through the windows meteor build system on v3.0.0:
|
That's interesting: changing the pangyp line to "http" causes the same symptomps as reported by the original poster: https:// seems to work better. |
Unsurprising. Github is https only.
|
Thanks @saper! I would say, lets pursue this here: rvagg/archived-pangyp#5. @rvagg, could you please publish pangyp vNext to npm after the merge? Thanks in anticipation. 🎁 |
CI seems pretty unhappy about this. |
Pin am11/pangyp to the particular commit
This doesn't appear to be a usable solution. We need to wait until it's solved upstream. Addressing this in #942 for now. |
Pin am11/pangyp to the particular commit
Should fix the problem mentioned in:
579baf3#commitcomment-11082041