Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

Ensure am11/pangyp not fetched via SSH #931

Closed
wants to merge 1 commit into from
Closed

Conversation

saper
Copy link
Member

@saper saper commented May 7, 2015

Pin am11/pangyp to the particular commit

Should fix the problem mentioned in:
579baf3#commitcomment-11082041

saper referenced this pull request May 7, 2015
Before building, first apply the following patch
to pangyp: rvagg/archived-pangyp#5 (until it is merged).

Issue URL: #870.
@@ -57,7 +57,7 @@
"mkdirp": "^0.5.0",
"nan": "^1.8.4",
"npmconf": "^2.1.1",
"pangyp": "am11/pangyp",
"pangyp": "git://github.com/am11/pangyp.git#f13599f5198b853948429062c2b334010a337342",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we not just default to the https endpoint to avoid any ssh issues?

@fourseven
Copy link
Contributor

I have this problem through the windows meteor build system on v3.0.0:

C:\Users\Mathew Hartley>  meteor publish-for-arch fourseven:[email protected]
compileScss: updating npm dependencies -- node-sass, lodash, autoprefixer-core...
npm WARN package.json [email protected] No description
npm WARN package.json [email protected] No repository field.
npm WARN package.json [email protected] No README data
npm ERR! Windows_NT 6.2.9200
npm ERR! argv "C:\\Users\\Mathew
Hartley\\AppData\\Local\\.meteor\\packages\\meteor-tool\\1.1.3\\mt-os.windows.x86_32\\dev_bundle\\bin\\\\node.exe"
"C:\\Users\\Mathew
Hartley\\AppData\\Local\\.meteor\\packages\\meteor-tool\\1.1.3\\mt-os.windows.x86_32\\dev_bundle\\bin\\node_modules\\npm\\bin\\npm-cli.js"
"install"
npm ERR! node v0.10.36
npm ERR! npm  v2.7.3
npm ERR! code ETARGET

npm ERR! notarget No compatible version found:
pangyp@'git+ssh://[email protected]/am11/pangyp.git#f13599f5198b853948429062c2b334010a337342'
npm ERR! notarget Valid install targets:
npm ERR! notarget ["2.0.0","2.0.1","2.0.2","2.1.0"]
npm ERR! notarget
npm ERR! notarget This is most likely not a problem with npm itself.
npm ERR! notarget In most cases you or one of your dependencies are requesting
npm ERR! notarget a package version that doesn't exist.
npm ERR! notarget
npm ERR! notarget It was specified as a dependency of 'node-sass'
npm ERR! notarget


=> Errors while initializing project:

While building plugin `compileScss` in package `fourseven:scss`:
error: couldn't install npm packages from npm-shrinkwrap

@saper
Copy link
Member Author

saper commented May 7, 2015

That's interesting:

changing the pangyp line to "http" causes the same symptomps as reported by the original poster:

https://gist.github.com/941c4f5c16f30d88efb2

https:// seems to work better.

@xzyfer
Copy link
Contributor

xzyfer commented May 7, 2015

Unsurprising. Github is https only.
On 7 May 2015 23:44, "Marcin Cieślak" [email protected] wrote:

That's interesting:

changing the pangyp line to "http" causes the same symptomps as reported
by the original poster:

https://gist.github.com/941c4f5c16f30d88efb2

https:// seems to work better.


Reply to this email directly or view it on GitHub
#931 (comment).

@am11
Copy link
Contributor

am11 commented May 8, 2015

Thanks @saper! I would say, lets pursue this here: rvagg/archived-pangyp#5.

@rvagg, could you please publish pangyp vNext to npm after the merge? Thanks in anticipation. 🎁

@xzyfer
Copy link
Contributor

xzyfer commented May 8, 2015

CI seems pretty unhappy about this.

Pin am11/pangyp to the particular commit
@xzyfer
Copy link
Contributor

xzyfer commented May 9, 2015

This doesn't appear to be a usable solution. We need to wait until it's solved upstream. Addressing this in #942 for now.

@saper saper closed this May 9, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants