This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
build: Adds win_delay_hook so iojs runs with alias #926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @am11, do we need to ship this for 3.0.0? |
Before building, first apply the following patch to pangyp: rvagg/archived-pangyp#5 (until it is merged). Issue URL: sass#870.
|
I think yes as this change has no side effect. |
|
This actually fixes that module registration bug on Windows (so it has +ve effect). :) |
|
Argh alright. I guess I can revoke the tag since we haven't created the release :) /cc @saper if you figure out what's up with the FreeBSD watcher we can ship it in 3.0.0. |
|
This change has no effect for us until we inherit objects from v8 or something like that, right? |
|
I believe it's related to node-sass install script failing with windows on iojs |
|
This doesn't affect the 3.0.0 node-sass-binaries so I'll ship this and re-tag v3.0.0. |
xzyfer
added a commit
that referenced
this pull request
May 6, 2015
build: Adds win_delay_hook so iojs runs with alias
jiongle1
pushed a commit
to scantist-ossops-m2/node-sass
that referenced
this pull request
Apr 7, 2024
Fix parsing and output of unknown at-rules (Fixes sass#855)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before building, first apply the following patch
to pangyp: rvagg/archived-pangyp#5 (until it is merged).
Issue URL: #870.