chore: Add Node 15 support #2983

nschonni · 2020-09-29T05:21:11Z

This should fail till the actual v15 of Node comes out.
Platform compiler requirements based off of nodejs/build#2423

nschonni · 2020-10-21T00:59:18Z

@xzyfer any idea why the binding isn't being picked up in 15?

> mocha test/{*,**/**}.js


Error: ENOENT: no such file or directory, scandir '/home/runner/work/node-sass/node-sass/vendor'
    at Object.readdirSync (node:fs:1025:3)
    at Object.getInstalledBinaries (/home/runner/work/node-sass/node-sass/lib/extensions.js:134:13)
    at foundBinariesList (/home/runner/work/node-sass/node-sass/lib/errors.js:20:15)
    at foundBinaries (/home/runner/work/node-sass/node-sass/lib/errors.js:15:5)
    at Object.module.exports.missingBinary (/home/runner/work/node-sass/node-sass/lib/errors.js:45:5)
    at module.exports (/home/runner/work/node-sass/node-sass/lib/binding.js:15:30)
    at Object.<anonymous> (/home/runner/work/node-sass/node-sass/lib/index.js:13:35)
    at Module._compile (node:internal/modules/cjs/loader:1083:30)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1112:10)
    at Module.load (node:internal/modules/cjs/loader:948:32)
    at Function.Module._load (node:internal/modules/cjs/loader:789:14)
    at Module.require (node:internal/modules/cjs/loader:972:19)
    at require (node:internal/modules/cjs/helpers:88:18)
    at Object.<anonymous> (/home/runner/work/node-sass/node-sass/test/api.js:10:10)
    at Module._compile (node:internal/modules/cjs/loader:1083:30)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1112:10)
    at Module.load (node:internal/modules/cjs/loader:948:32)
    at Function.Module._load (node:internal/modules/cjs/loader:789:14)
    at Module.require (node:internal/modules/cjs/loader:972:19)
    at require (node:internal/modules/cjs/helpers:88:18)
    at Object.exports.requireOrImport (/home/runner/work/node-sass/node-sass/node_modules/mocha/lib/esm-utils.js:20:12)
    at Object.exports.loadFilesAsync (/home/runner/work/node-sass/node-sass/node_modules/mocha/lib/esm-utils.js:33:34)
    at Mocha.loadFilesAsync (/home/runner/work/node-sass/node-sass/node_modules/mocha/lib/mocha.js:431:19)
    at singleRun (/home/runner/work/node-sass/node-sass/node_modules/mocha/lib/cli/run-helpers.js:125:15)
    at exports.runMocha (/home/runner/work/node-sass/node-sass/node_modules/mocha/lib/cli/run-helpers.js:190:10)
    at Object.exports.handler (/home/runner/work/node-sass/node-sass/node_modules/mocha/lib/cli/run.js:362:11)
    at /home/runner/work/node-sass/node-sass/node_modules/yargs/lib/command.js:241:49

Happening in Actions an AppVeyor, so it doesn't seem CI specific

xzyfer · 2020-10-21T01:06:45Z

Looks like a duplicate node-sass has crept into the path. Maybe there were changes in this space recently.

-/home/runner/work/node-sass/node-sass/vendor
+/home/runner/work/node-sass/vendor

nschonni · 2020-10-21T01:16:18Z

Odd, it's building to that folder too

gyp info ok 
Installed to /home/runner/work/node-sass/node-sass/vendor/linux-x64-88/binding.node

nschonni · 2020-10-21T02:08:46Z

OK, I tried it locally in WSL after installing 15 through NVM. It seems like after the build, the binding file isn't copied to the the folder like the name suggests.

It has the line at the end of the build ln -f "Release/obj.target/binding.node" "Release/binding.node" 2>/dev/null || (rm -rf "Release/binding.node" && cp -af "Release/obj.target/binding.node" "Release/binding.node"), but it looks like there are no links created. There is a "vendor" folder while its building, but disappears at the end.

nschonni · 2020-10-21T04:21:50Z

Tried cherry-picking the mkdirp bump over, and even tried moving it all sync, but no luck yet. Maybe something node-gyp related since it seems to be failing to ln/copy the built file up to build/Release/binding.node

nschonni · 2020-10-22T00:24:00Z

@xzyfer Success! turns out that only in-publish script was the issue and was triggering the prepublish job. Since we don't need to support NPM 4 anymore, I stripped it out and it's passing now.
Only remaining thing is the Alpine binaries. Not sure if you want to cut the release and wait for them to catch up or not

xzyfer · 2020-10-22T00:47:02Z

Awesome!
I can cut the alpine binaries locally tonight in the worst case.

nschonni · 2020-10-22T00:54:40Z

OK, i'm working on the upstream issues blocking the Node Alpine release, but I don't think it will be resolved in the next few hours

xzyfer · 2020-10-22T01:06:42Z

If the release is created I can attached the alpine releases and publish the package after work.

…

On Thu, 22 Oct 2020, 11:54 am Nick Schonning, ***@***.***> wrote: OK, i'm working on the upstream issues blocking the Node Alpine release, but I don't think it will be resolved in the next few hours — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2983 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAENSWGSNG5LJ5JNSKRI7JDSL57F5ANCNFSM4R5KHQEA> .

nschonni · 2020-10-22T19:09:38Z

@xzyfer Node Apline is out. Reset the job, but a bunch of the CLI tests are failing

nschonni · 2020-10-26T21:10:50Z

@xzyfer should we just land this and see if you can build the Alpine binaries locally?

xzyfer · 2020-10-26T22:43:02Z

Yeah. I can't add the binaries after work..I'm still curious as to whether the Linux binaries will work for folks too.

…

On Tue, 27 Oct 2020, 8:11 am Nick Schonning, ***@***.***> wrote: @xzyfer <https://github.com/xzyfer> should we just land this and see if you can build the Alpine binaries locally? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2983 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAENSWHBDTEBOVKCNKT3EB3SMXQWRANCNFSM4R5KHQEA> .

nschonni · 2020-10-27T01:35:02Z

We could always change the Linux build to use a different distro than Ubuntu, if you think it would offer better compatibility

xzyfer · 2020-10-27T05:24:51Z

I'm going to merge this to cut the release. Lets see how the new binaries perform given the limited Node release support.

xzyfer · 2020-10-27T05:33:43Z

Took a swing at a draft release https://github.com/sass/node-sass/releases/tag/v5.0.0.

What's the process to kick off artifacts uploads?

nschonni · 2020-10-27T16:39:35Z

They're all on the build for the merge to master EX: the Artifacts download on https://github.com/sass/node-sass/runs/1312916049, and for each of the other platform jobs. Looks like you need to click on one of the individual version jobs before that menu shows up :/

xzyfer · 2020-10-27T19:29:59Z

I'm currently moving house so it may be sometime before I can get to this

…

On Wed, 28 Oct 2020, 3:39 am Nick Schonning, ***@***.***> wrote: They're all on the build for the merge to master EX: the Artifacts download on https://github.com/sass/node-sass/runs/1312916049, and for each of the other platform jobs. Looks like you need to click on one of the individual version jobs before that menu shows up :/ — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#2983 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAENSWBPTFBOOGBMHKE5BCLSM3ZVTANCNFSM4R5KHQEA> .

nschonni · 2020-10-27T19:41:25Z

No worries, I'll see if I can collect the bindings and add them to the draft release

niemyjski · 2020-10-27T21:40:12Z

Can someone please post an update when npm has the artifacts. Currently getting No matching version found for....

xzyfer · 2020-10-31T13:55:27Z

Sorry for the delay I've been moving house. I noticed you added the Windows binaries. I've added the Node 15 Alpine binary, removed the prelease status from the release, and published the npm package.

nschonni · 2020-10-31T14:17:32Z

@xzyfer I only added x64 Windows binaries, I couldn't get the x86 ones from AppVeyor

xzyfer · 2020-10-31T14:31:22Z

Kicked off an appveyor build for the windows binaries. They should be added to the release automatically.

https://ci.appveyor.com/project/sass/node-sass/builds/36067507

nschonni · 2020-10-31T15:51:08Z

Yup, look like that worked

nschonni marked this pull request as ready for review October 20, 2020 04:42

nschonni mentioned this pull request Oct 20, 2020

Node 15 Support #2965

Closed

4 tasks

nschonni force-pushed the node-15 branch from 1bb60f3 to 744de60 Compare October 20, 2020 17:54

chore: Add Node 15 support

0963512

nschonni force-pushed the node-15 branch from 744de60 to e5a94ac Compare October 22, 2020 00:08

chore: Remove in-publish for native prepublishOnly

1270f04

nschonni force-pushed the node-15 branch from e5a94ac to 1270f04 Compare October 22, 2020 00:14

nschonni mentioned this pull request Oct 23, 2020

Release with node-gyp 7.1.0 #3009

Closed

xzyfer merged commit 0648b5a into sass:master Oct 27, 2020

nschonni deleted the node-15 branch October 27, 2020 16:36

nschonni mentioned this pull request Oct 27, 2020

feat: Update to 5.0.0 #3012

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Add Node 15 support #2983

chore: Add Node 15 support #2983

nschonni commented Sep 29, 2020 •

edited

Loading

nschonni commented Oct 21, 2020

xzyfer commented Oct 21, 2020

nschonni commented Oct 21, 2020

nschonni commented Oct 21, 2020

nschonni commented Oct 21, 2020

nschonni commented Oct 22, 2020

xzyfer commented Oct 22, 2020

nschonni commented Oct 22, 2020

xzyfer commented Oct 22, 2020 via email

nschonni commented Oct 22, 2020

nschonni commented Oct 26, 2020

xzyfer commented Oct 26, 2020 via email

nschonni commented Oct 27, 2020

xzyfer commented Oct 27, 2020

xzyfer commented Oct 27, 2020

nschonni commented Oct 27, 2020

xzyfer commented Oct 27, 2020 via email

nschonni commented Oct 27, 2020

niemyjski commented Oct 27, 2020

xzyfer commented Oct 31, 2020

nschonni commented Oct 31, 2020

xzyfer commented Oct 31, 2020

nschonni commented Oct 31, 2020

chore: Add Node 15 support #2983

chore: Add Node 15 support #2983

Conversation

nschonni commented Sep 29, 2020 • edited Loading

nschonni commented Oct 21, 2020

xzyfer commented Oct 21, 2020

nschonni commented Oct 21, 2020

nschonni commented Oct 21, 2020

nschonni commented Oct 21, 2020

nschonni commented Oct 22, 2020

xzyfer commented Oct 22, 2020

nschonni commented Oct 22, 2020

xzyfer commented Oct 22, 2020 via email

nschonni commented Oct 22, 2020

nschonni commented Oct 26, 2020

xzyfer commented Oct 26, 2020 via email

nschonni commented Oct 27, 2020

xzyfer commented Oct 27, 2020

xzyfer commented Oct 27, 2020

nschonni commented Oct 27, 2020

xzyfer commented Oct 27, 2020 via email

nschonni commented Oct 27, 2020

niemyjski commented Oct 27, 2020

xzyfer commented Oct 31, 2020

nschonni commented Oct 31, 2020

xzyfer commented Oct 31, 2020

nschonni commented Oct 31, 2020

nschonni commented Sep 29, 2020 •

edited

Loading