Allow setting of SASS_BINARY_DIR without setting explicit binary name

[kausters]

I'm at a company with people developing on multiple platforms behind a strict firewall. I want to host precompiled SASS bindings locally so setting SASS_BINARY_URL doesn't work for me. However I do not want to use SASS_BINARY_PATH because it requires giving explicit file name of the binding which doesn't work when some developers are on Macs, some on WIndows, and the whole project is compiled on Linux for production — it is quite a pain to set the full path as required in each environment, and as far as I know impossible within a static .npmrc file (.npmrc supports expansion of environment variables but I'd still need to set the SASS version, OS arch & Node Modules version).

Introducing: SASS_BINARY_DIR! Enables setting a directory where the binaries are stored but uses the default file name which SASS figures out by itself.

Also updated the getBinaryPath to use the new getBinaryDir.

[xzyfer]

Thanks! Conceptually i support the idea, I'll need some time to look over the implementation.

…

On 21 Oct. 2017 1:11 pm, "Kristaps" ***@***.***> wrote: I'm at a company with people developing on multiple platforms behind a strict firewall. I want to host precompiled SASS bindings locally so setting SASS_BINARY_URL doesn't work for me. However I do not want to use SASS_BINARY_PATH because it requires giving explicit file name of the binding which doesn't work when some developers are on Macs, some on WIndows, and the whole project is compiled on Linux for production — it is quite a pain to set the full path as required in each environment, and as far as I know impossible within a static .npmrc file. Introducing: SASS_BINARY_DIR! Enables setting a directory where the binaries are stored but uses the default file name which SASS figures out by itself. Also updated the getBinaryPath to use the new getBinaryDir. ------------------------------ You can view, comment on, or merge this pull request online at: #2119 Commit Summary - Allow setting of SASS_BINARY_DIR without setting explicit binary name File Changes - *M* lib/extensions.js <https://github.com/sass/node-sass/pull/2119/files#diff-0> (39) - *M* test/runtime.js <https://github.com/sass/node-sass/pull/2119/files#diff-1> (31) Patch Links: - https://github.com/sass/node-sass/pull/2119.patch - https://github.com/sass/node-sass/pull/2119.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#2119>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAjZWFINDDL7JBPWTRljI9phwPv-9QWmks5suVK8gaJpZM4QBZfo> .

[kausters]

Thanks! I mostly just reused the code for SASS_BINARY_PATH, let me know if I should change anything.

[xzyfer]

All good. There's currently another active PR working on sass binary path, and we're working the next major version of node sass is all

…

On 22 Oct. 2017 11:42 am, "Kristaps" ***@***.***> wrote: Thanks! I mostly just reused the code for SASS_BINARY_PATH, let me know if I should change anything. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#2119 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAjZWEDSQvRXPNTCaUImwNXmnHL9skA9ks5suo9pgaJpZM4QBZfo> .

[xzyfer]

Thanks for you work :) This will land in 4.8.0