Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

Add Node 8 to the support versions lists #1929

Merged
merged 2 commits into from
Mar 21, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/extensions.js
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ function getHumanNodeVersion(abi) {
case 47: return 'Node.js 5.x';
case 48: return 'Node.js 6.x';
case 51: return 'Node.js 7.x';
case 53: return 'Node.js 8.x';
default: return false;
}
}
Expand Down
21 changes: 5 additions & 16 deletions test/binding.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ var assert = require('assert'),
describe('binding', function() {
describe('missing error', function() {
it('should be useful', function() {
process.env.SASS_BINARY_NAME = 'Linux-x64-48';
process.env.SASS_BINARY_NAME = 'unknown-x64-48';

assert.throws(
function() { binding(etx); },
function(err) {
Expand Down Expand Up @@ -42,19 +43,15 @@ describe('binding', function() {

describe('on unsupported environment', function() {
describe('with an unsupported architecture', function() {
var prevValue;

beforeEach(function() {
prevValue = process.arch;

Object.defineProperty(process, 'arch', {
value: 'foo',
});
});

afterEach(function() {
Object.defineProperty(process, 'arch', {
value: prevValue,
value: 'x64',
});
});

Expand All @@ -74,19 +71,15 @@ describe('binding', function() {
});

describe('with an unsupported platform', function() {
var prevValue;

beforeEach(function() {
prevValue = process.platform;

Object.defineProperty(process, 'platform', {
value: 'bar',
});
});

afterEach(function() {
Object.defineProperty(process, 'platform', {
value: prevValue,
value: 'darwin',
});
});

Expand All @@ -106,19 +99,15 @@ describe('binding', function() {
});

describe('with an unsupported runtime', function() {
var prevValue;

beforeEach(function() {
prevValue = process.versions.modules;

Object.defineProperty(process.versions, 'modules', {
value: 'baz',
});
});

afterEach(function() {
Object.defineProperty(process.versions, 'modules', {
value: prevValue,
value: 51,
});
});

Expand Down