feat: Node 18 and 19 support and drop Node 17 (#3257)

Fixes #3251
sass · Nov 9, 2022 · 98e75b3 · 98e75b3
1 parent e9bb866
commit 98e75b3
Show file tree

Hide file tree

Showing 7 changed files with 25 additions and 18 deletions.
diff --git a/.github/workflows/alpine.yml b/.github/workflows/alpine.yml
@@ -16,9 +16,10 @@ jobs:
       matrix:
         node:
           - 14
-          # Node 16 and 17 are perma-red for the tests right now
+          # Node 16+ are perma-red for the tests right now
           # - 16
-          # - 17
+          # - 18
+          # - 19
 
     steps:
       - name: Install Alpine build tools

diff --git a/.github/workflows/linux.yml b/.github/workflows/linux.yml
@@ -16,7 +16,7 @@ jobs:
         node:
           - 14
           - 16
-          - 17
+          - 18
 
         include:
           - node: 14
@@ -27,10 +27,14 @@ jobs:
             gcc: "gcc-8"
             gpp: "g++-8"
             os: ubuntu-18.04
-          - node: 17
+          - node: 18
             gcc: "gcc-8"
             gpp: "g++-8"
-            os: ubuntu-18.04
+            os: ubuntu-20.04
+          - node: 19
+            gcc: "gcc-8"
+            gpp: "g++-8"
+            os: ubuntu-20.04
 
 
     steps:

diff --git a/.github/workflows/macos.yml b/.github/workflows/macos.yml
@@ -16,7 +16,8 @@ jobs:
         node:
           - 14
           - 16
-          - 17
+          - 18
+          - 19
 
     steps:
       - uses: actions/checkout@v3

diff --git a/.github/workflows/windows.yml b/.github/workflows/windows.yml
@@ -8,28 +8,21 @@ on:
 
 jobs:
   build:
-    runs-on: ${{ matrix.os }}
+    runs-on: windows-2019
 
     strategy:
       fail-fast: false
       matrix:
         node:
           - 14
           - 16
-          - 17
+          - 18
+          - 19
 
         architecture:
           - x64
           - x86
 
-        include:
-          - node: 14
-            os: windows-2019
-          - node: 16
-            os: windows-2019
-          - node: 17
-            os: windows-2019
-
     steps:
       - uses: actions/checkout@v3
 

diff --git a/README.md b/README.md
@@ -17,7 +17,9 @@ Below is a quick guide for minimum and maximum supported versions of node-sass:
 
 NodeJS  | Supported node-sass version | Node Module
 --------|-----------------------------|------------
-Node 17 | 7.0+                        | 102
+Node 19 | 8.0+                        | 111
+Node 18 | 8.0+                        | 108
+Node 17 | 7.0+, <8.0                  | 102
 Node 16 | 6.0+                        | 93
 Node 15 | 5.0+, <7.0                  | 88
 Node 14 | 4.14+                       | 83

diff --git a/appveyor.yml b/appveyor.yml
@@ -39,9 +39,13 @@
       - nodejs_version: 16
         GYP_MSVS_VERSION: 2019
         APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2019
-      - nodejs_version: 17
+      - nodejs_version: 18
         GYP_MSVS_VERSION: 2019
         APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2019
+      - nodejs_version: 19
+        GYP_MSVS_VERSION: 2019
+        APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2019
+
 
   install:
     # https://www.appveyor.com/docs/lang/nodejs-iojs/#installing-any-version-of-nodejs-or-iojs

diff --git a/lib/extensions.js b/lib/extensions.js
@@ -82,6 +82,8 @@ function getHumanNodeVersion(abi) {
     case 88: return 'Node.js 15.x';
     case 93: return 'Node.js 16.x';
     case 102: return 'Node.js 17.x';
+    case 108: return 'Node.js 18.x';
+    case 111: return 'Node.js 19.x';
     default: return false;
   }
 }