Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve C++ compiler compatibility #2385

Merged
merged 1 commit into from
May 20, 2017
Merged

Improve C++ compiler compatibility #2385

merged 1 commit into from
May 20, 2017

Conversation

mgreter
Copy link
Contributor

@mgreter mgreter commented May 20, 2017

std::to_string is not available in GCC 4.6.3

@mgreter
Improve C++ compiler compatibility
e497f4f 
std::to_string is not available in GCC 4.6.3
@mgreter mgreter self-assigned this May 20, 2017
@mgreter mgreter merged commit 0ebe9f1 into sass:master May 20, 2017
@xzyfer
Copy link
Contributor

xzyfer commented May 30, 2017 •
edited
Loading

All the variations of the rgb, rgba, hsl, hslafunction useto_string`. Any reason only this call site was changed?

@mgreter
Copy link
Contributor Author

mgreter commented May 30, 2017

It was the only one failing on my compiler

@mgreter
Copy link
Contributor Author

mgreter commented May 30, 2017

And std::to_string is not the same as AST::to_string, or did I miss something?

@xzyfer xzyfer added this to the 3.5.0.beta.4 milestone May 30, 2017
@xzyfer
Copy link
Contributor

xzyfer commented May 30, 2017

No, you're correct. My mistake

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mgreter mgreter

Labels
Dev - PR Ready
Projects
None yet
Milestone
3.5.0.beta.4
Development

Successfully merging this pull request may close these issues.
2 participants
@mgreter @xzyfer