-
Notifications
You must be signed in to change notification settings - Fork 466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Possible to output invalid CSS with a @function #2569
Comments
This PR add specs for sass/libsass#2569
We treat `@else` as a block which breaks the check nesting algorithm ported over from Ruby Sass. With change the intermediate `Block` to container `@else` children is invisible. This better emulates the the Ruby Sass algorithm. Fixes sass#2569
This PR add specs for sass/libsass#2569
Thanks @chriscoyier. This is an issue with how we validate |
This PR add specs for sass/libsass#2569
This PR add specs for sass/libsass#2569
This PR add specs for sass/libsass#2569
We treat `@else` as a block which breaks the check nesting algorithm ported over from Ruby Sass. With change the intermediate `Block` to container `@else` children is invisible. This better emulates the the Ruby Sass algorithm. Fixes #2569
This probably isn't the perfect place to ask this, so feel free to shoo me there. I'm curious how the rollouts work. This eventually goes into a point release for libsass, right? Then implementations of it need to update to that version, so if we're using Node, we wait for the next point release of node-sass? |
Yep that's pretty much how it goes. Luckily I'm the maintainer of node-sass also so the turn around is pretty fast once we make a LibSass release. |
We treat `@else` as a block which breaks the check nesting algorithm ported over from Ruby Sass. With change the intermediate `Block` to container `@else` children is invisible. This better emulates the the Ruby Sass algorithm. Fixes #2569
input.scss
Actual results
Libsass 3.5
Expected result
Throw an error like
http://libsass.ocbnet.ch/srcmap/#QGZ1bmN0aW9uIHRlc3QoKSB7CiAgQGlmIChmYWxzZSkgewogICAgQHJldHVybiAwOwogIH0gQGVsc2UgewogICAgb3BhY2l0eTogMTsKICB9Cn0KCi5teS1tb2R1bGUgewogIG9wYWNpdHk6IHRlc3QoKTsKfQo=
Spec sass/sass-spec#1218
The text was updated successfully, but these errors were encountered: