Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scientific notation should be supported for numbers/percentages/dimensions #2465

Closed
ThomasBrierley opened this issue Aug 9, 2017 · 2 comments
Closed

Scientific notation should be supported for numbers/percentages/dimensions #2465

ThomasBrierley opened this issue Aug 9, 2017 · 2 comments
Assignees
@mgreter
Labels
Dev - Test Written Sass 3.4 Compatibility Sass 3.4 Sass 3.5 Sass 4.0

Comments

@ThomasBrierley
Copy link

ThomasBrierley commented Aug 9, 2017 •
edited by xzyfer
Loading

Input

foo {
  a: 1e1px;
  b: 1e-1px;
}

LibSass 3.5.0-beta.2

Error: Incompatible units: 'px' and 'e'.
        on line 3 of test.scss
>>   b: 1e-1px;

Sass 3.5.1 (Bleeding Edge)

foo {
  a: 1e1px;
  b: 1e-1px; }

Version info

$ node-sass --version
node-sass       4.5.3   (Wrapper)       [JavaScript]
libsass         3.5.0.beta.2    (Sass Compiler) [C/C++]

Spec sass/sass-spec#1163
@ThomasBrierley ThomasBrierley changed the title E-Notation: negative exponents cause unit parsing error. E-Notation: exponent sign parsed as operator. Aug 9, 2017
@nschonni nschonni changed the title E-Notation: exponent sign parsed as operator. Scientific notation should be supported for numbers/percentages/dimensions Aug 9, 2017
@nschonni
Copy link
Collaborator

nschonni commented Aug 9, 2017

https://www.w3.org/TR/2014/CR-css-syntax-3-20140220/

Ruby Sass outpust both correctly in 3.5 and 4.0, but libsass has trouble with the negative version only
https://www.sassmeister.com/gist/bd4d877039b787fa24e35470eaa9c120

xzyfer added a commit to xzyfer/sass-spec that referenced this issue Aug 17, 2017
@xzyfer
Add specs for issue 2465
22c611d 
This PR add specs for sass/libsass#2465
@xzyfer xzyfer mentioned this issue Aug 17, 2017
Merged
@xzyfer
Copy link
Contributor

xzyfer commented Aug 17, 2017

Thanks for confirming this issue @nschonni. I've added the spec.

@xzyfer xzyfer mentioned this issue Aug 17, 2017
Closed
xzyfer added a commit to xzyfer/sass-spec that referenced this issue Aug 31, 2017
@xzyfer
Add specs for issue 2465
0f5b64c 
This PR add specs for sass/libsass#2465
@mgreter mgreter mentioned this issue Nov 11, 2017
Merged
@mgreter mgreter self-assigned this Nov 11, 2017
@mgreter mgreter mentioned this issue Nov 11, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mgreter mgreter

Labels
Dev - Test Written Sass 3.4 Compatibility Sass 3.4 Sass 3.5 Sass 4.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mgreter @xzyfer @nschonni @ThomasBrierley