-
Notifications
You must be signed in to change notification settings - Fork 466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@supports fails when passing variables #2452
Comments
Trying with Ruby 3.4.21 on sassmeister doesn't output anything. To find the version of node-sass installed with gulp-sass, try |
@nschonni node-sass is 4.5.3. |
Can you also confirm the Ruby Sass version as well, since I didn't get any output when trying on Sassmeister. |
Just running |
I'm not 💯 that the variables in the support query is supported, but using the div {
@supports(display: flow-root) {
display: flow-root;
}
} |
Ah, gotcha. It works using regular compilation, that's why I couldn't figure out why it wasn't working. Thanks for figuring that out! Hopefully this can be resolved at some point. |
I encountered this blocking situation while writing a
|
This issue is occurring for me on node-sass v4.7.2 any ideas if this will be fixed? |
The issue here is that Sass does not support $prop: display;
$val: flow-root;
div {
@supports ($prop: $val) {
$prop: $val;
}
} The following works as expected. $val: flow-root;
div {
@supports (display: $val) {
display: $val;
}
} There are a couple things here:
|
@xzyfer The Dart/Ruby output is intended. The issue isn't that $prop: display;
$val: flow-root;
div {
@supports ($prop: $val) {
#{$prop}: $val;
}
} Ruby and Dart Sass will both produce @supports (display: flow-root) {
div {
display: flow-root;
}
} |
@nex3 thanks for clearing that up. Makes total sense. |
This PR add specs for sass/libsass#2452
Emulate the parse behaviour of `@media` query declarations. Fixes sass#2452
This PR add specs for sass/libsass#2452
Emulate the parse behaviour of `@media` query declarations. Fixes #2452
This PR add specs for sass/libsass#2452
This PR add specs for sass/libsass#2452
This PR add specs for sass/libsass#2452
Emulate the parse behaviour of `@media` query declarations. Fixes #2452
input.scss
Actual results
node-sass 4.5.3 (via gulp)
Expected result
ruby sass 3.5.1
Spec sass/sass-spec#1219
The text was updated successfully, but these errors were encountered: