Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Makefile #14

Closed
andrew opened this issue Apr 27, 2012 · 5 comments · Fixed by #48
Closed

Improve Makefile #14

andrew opened this issue Apr 27, 2012 · 5 comments · Fixed by #48
Assignees

Comments

@andrew
Copy link

andrew commented Apr 27, 2012

I've created a homebrew formula so we can simply run brew install libsass but the Makefile doesn't have an install command.

I don't really know much about makefiles so I might need some help implementing it.

Homebrew formula here: andrew/homebrew@b5601ff

@ghost ghost assigned HamptonMakes Apr 27, 2012
@HamptonMakes
Copy link
Member

Yeah, I was working on this... make install is a bitch if its cross-compatible!

@andrew
Copy link
Author

andrew commented Apr 27, 2012

For the moment I'm going to vender libsass into node-sass and compile it all on install as libsass as no other dependencies.

@HamptonMakes
Copy link
Member

That's the main method I was assuming for integration! So small anyway..

  • Hampton

On Apr 27, 2012, at 2:42 PM, Andrew [email protected] wrote:

For the moment I'm going to vender libsass into node-sass and compile it all on install as libsass as no other dependencies.


Reply to this email directly or view it on GitHub:
#14 (comment)

This was referenced Oct 14, 2012
@craigbarnes
Copy link
Contributor

I've created a homebrew formula so we can simply run brew install libsass but the Makefile doesn't have an install command.

I added make install in a7ddccf. It should work on at least Linux and OS X.

That's the main method I was assuming for integration! So small anyway.

Bundling libraries and static linking is a bit of a show stopper for packaging for Linux distros.

HamptonMakes pushed a commit that referenced this issue Oct 2, 2014
Check for single quotes on import statements
@HamptonMakes
Copy link
Member

I think this is sorted already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants