Guard against FileNotFoundError #227
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
python2+python3 compatibility: should use |
asottile
reviewed
Nov 29, 2017
sass.py
Outdated
| @@ -50,6 +50,9 @@ | |||
| #: (:class:`collections.Set`) The set of keywords :func:`compile()` can take. | |||
| MODES = set(['string', 'filename', 'dirname']) | |||
|
|
|||
| if PY2: | |||
| FileNotFoundError = OSError | |||
|
|
|||
There was a problem hiding this comment.
instead of this, just use OSError in the except block
|
@asottile Yeah, I noticed the failing tests – updated as per your preference. |
asottile
reviewed
Nov 29, 2017
| # #208: cwd is always included in include paths, if possible | ||
| try: | ||
| include_paths = (os.getcwd(),) | ||
| except OSError: |
There was a problem hiding this comment.
worth calling out why this OSError can occur, perhaps something like: "if the current working directory has been deleted, getcwd() will raise"
might also be good to write a quick regression test to demonstrate this -- let me know if you'd like some help with this -- it should be pretty easy to start with something like this:
def test_compile_in_missing_dir(tmpdir):
does_not_exist = tmpdir.join('does_not_exist').ensure_dir()
with does_not_exist.as_cwd():
does_not_exist.remove()
# run a compile from here
|
I actually tried writing such a test, I'm not sure this ever worked: |
|
So how do you want to proceed? |
|
I like the patch, I'm going to try and fix this upstream as well: sass/libsass#2513 |
|
It may also be time for us to ditch the 3.4.x releases and move to the 3.5 betas -- even though they're "beta" |
|
Any news on this? |
|
Yes! Upstream merged a change related to this -- though it still crashes just in a different way now: Here's the full test I'm using: import sass
def test_compile_in_missing_dir(tmpdir):
f = tmpdir.join('f.scss')
f.write('a{color: red;}')
dne = tmpdir.join('does_not_exist').ensure_dir()
with dne.as_cwd():
dne.remove()
sass.compile(filename=str(f))Looking back at previous versions, it seems this has never worked though: 0.13.2 - 0.13.7 have the 0.13.1 and 0.13.0 and 0.12.3 crash in the same way Even against the beta (which removes cwd from the search path): So I think it's safe to say this never worked, and never will work :( |
|
Strange, because for me it worked as long as I pinned libsass to 0.13.1 … |
|
0.13.1 uses libsass 3.4.5 This line is going to crash if pwd is missing: https://github.com/sass/libsass/blob/3.4.5/src/context.cpp#L63 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into this issue in production –
os.getcwd()may raise aFileNotFoundError.