Another implicit dependency fix #1352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nex3
approved these changes
Jun 11, 2021
lib/src/async_environment.dart
Outdated
| @@ -837,7 +809,7 @@ class AsyncEnvironment { | |||
| Module toModule(CssStylesheet css, ExtensionStore extensionStore) { | |||
| assert(atRoot); | |||
| return _EnvironmentModule(this, css, extensionStore, | |||
| forwarded: _forwardedModules); | |||
| forwarded: _forwardedModules?.keys.toSet()); | |||
There was a problem hiding this comment.
It would probably be more efficient to use a MapKeySet here, unless there's a reason it shouldn't update if _forwardedModules is modified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't yet worked out a fix for the at-root issue, but this fix is actually necessary for the internal division migration.
This splits out
_globalModulesinto two fields: one that contains@use as *global modules and one that contains modules that come from@import-ing a@forward.See sass/sass-spec#1667.