Fix custom property parsing in plain CSS #1108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Awjin
approved these changes
Oct 7, 2020
| @@ -503,8 +503,11 @@ abstract class StylesheetParser extends Parser { | |||
| /// This is only used in contexts where declarations are allowed but style | |||
| /// rules are not, such as nested declarations. Otherwise, | |||
| /// [_declarationOrStyleRule] is used instead. | |||
| @protected | |||
There was a problem hiding this comment.
I'm not sure why it was there in the first place—the method is private, so it can't be referenced from subclasses anyway (unless those subclasses are in the same file which they aren't).
Co-authored-by: Awjin Ahn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1104
See sass/sass-spec#1575