Make user field optional in embedding request#899
Merged
sashabaranov merged 3 commits intosashabaranov:masterfrom Nov 20, 2024
Merged
Make user field optional in embedding request#899sashabaranov merged 3 commits intosashabaranov:masterfrom
sashabaranov merged 3 commits intosashabaranov:masterfrom
Conversation
Owner
|
@nagar-ajay thank you for the PR! Please the latest changes from |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #899 +/- ##
==========================================
+ Coverage 98.46% 98.86% +0.40%
==========================================
Files 24 26 +2
Lines 1364 1761 +397
==========================================
+ Hits 1343 1741 +398
+ Misses 15 14 -1
Partials 6 6 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Contributor
Author
|
Updated the PR. |
sashabaranov
approved these changes
Nov 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the change
Added
omitemptyjson tag for theUserfield in theEmbeddingRequeststruct. This field is optional in embedding requests as per OpenAI spec.Issue: If you don't specify any user in the embedding request, the current spec sends the user as an empty string for which embedding models throw errors.
Provide OpenAI documentation link
https://platform.openai.com/docs/api-reference/embeddings/create#embeddings-create-user
Describe your solution
Added
omitemptyjson tag for theUserfield in theEmbeddingRequeststruct. This will make theUserfield optional as per openai embeddings spec.Tests
Tested the above change by sending embeddings requests to the embeddings model with following payload: