Support Retrieve file content API (#347)#348
Merged
sashabaranov merged 2 commits intosashabaranov:masterfrom Jun 11, 2023
Merged
Support Retrieve file content API (#347)#348sashabaranov merged 2 commits intosashabaranov:masterfrom
sashabaranov merged 2 commits intosashabaranov:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #348 +/- ##
==========================================
+ Coverage 93.65% 95.22% +1.57%
==========================================
Files 17 17
Lines 646 670 +24
==========================================
+ Hits 605 638 +33
+ Misses 30 22 -8
+ Partials 11 10 -1
|
Collaborator
Author
|
@sashabaranov Please check it. Thank you always for reviewing. |
sashabaranov
approved these changes
Jun 11, 2023
Owner
sashabaranov
left a comment
sashabaranov
left a comment
There was a problem hiding this comment.
Thank you so much for this PR! I love the decreased duplication and increased test coverage 🙌🏻
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a pull request for #347, I implemented the Retrieve file content API.
The return value of the
GetFileContentfunction isio.ReadCloser. Because library users flexibility in handling the response.