move request_builder into internal pkg (#304)#329
Merged
sashabaranov merged 3 commits intosashabaranov:masterfrom May 31, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #329 +/- ##
==========================================
+ Coverage 92.36% 92.45% +0.08%
==========================================
Files 19 18 -1
Lines 655 636 -19
==========================================
- Hits 605 588 -17
+ Misses 37 35 -2
Partials 13 13
|
Collaborator
Author
|
@sashabaranov Please check it. |
Owner
|
@vvatanabe thank you for the PR! Could you please update the tests so the coverage would not go down? |
8e9c035 to
ef47d31
Compare
ef47d31 to
a6d1c8f
Compare
Collaborator
Author
|
@sashabaranov The following tests were added to increase coverage.
FYI: We can view the codes not covered by the following commands in browser. It was very easy to detect. |
sashabaranov
approved these changes
May 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #304 (request_builder)
I moved the following files to the internal package.
Internal/request_builder_test.go was circularly referenced. So I moved the following test to client_test.go. They are tests for error cases resulting from calls to methods of openai.Client. So I decided it was appropriate to move them to client_test.go.