Adjust the azure model deployment name call corresponding to README#309
Merged
sashabaranov merged 11 commits intosashabaranov:masterfrom May 15, 2023
zjy282:master
Merged
Adjust the azure model deployment name call corresponding to README#309sashabaranov merged 11 commits intosashabaranov:masterfrom zjy282:master
sashabaranov merged 11 commits intosashabaranov:masterfrom
zjy282:master
Conversation
Codecov Report
@@ Coverage Diff @@
## master #309 +/- ##
=======================================
Coverage 92.63% 92.63%
=======================================
Files 22 22
Lines 679 679
=======================================
Hits 629 629
Misses 37 37
Partials 13 13 |
Owner
|
Thank you for the PR! |
| config := openai.DefaultAzureConfig("your Azure OpenAI Key", "https://your Azure OpenAI Endpoint ", "your Model deployment name") | ||
| config := openai.DefaultAzureConfig("your Azure OpenAI Key", "https://your Azure OpenAI Endpoint") | ||
| config.AzureModelMapperFunc = func(model string) string { | ||
| azureModelMapping = []string{ |
Owner
There was a problem hiding this comment.
Thank you for the PR! Could you please comment out the config.AzureModelMapperFunc section and clearly indicate that it is optional?
Contributor
Author
There was a problem hiding this comment.
Of course, great idea
|
I've try it in my application and it should be: |
Modify variable type definition error
Contributor
Author
This problem has been fixed, thanks |
sashabaranov
approved these changes
May 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the modification of #306, adjust the azure model deployment name call corresponding to README