Skip to content

improvement client constructor and add option pattern #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ja7ad wants to merge 4 commits into from
Closed

improvement client constructor and add option pattern #278

ja7ad wants to merge 4 commits into from

Conversation

@ja7ad
Copy link

@ja7ad ja7ad commented Apr 24, 2023

No description provided.

@sashabaranov
Copy link
Owner

sashabaranov commented Apr 24, 2023

Hey, thank you for the PR, your effort is greatly appreciated! This library uses a config-struct-based approach, and to keep things consistent, we are not going to add an option-based one.

See also: #79, #214

@sashabaranov sashabaranov mentioned this pull request May 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ja7ad @sashabaranov