Specify the right event type InputEvent for the input event #240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: orta <[email protected]>
* Use node16 * - * Set submodule to 49ff45b
Co-authored-by: orta <[email protected]>
Author
|
ah I know it's a submodule! |
Author
|
The PR is ready now, sorry for the noise :-) |
saschanaz
reviewed
Aug 21, 2025
Owner
saschanaz
left a comment
saschanaz
left a comment
There was a problem hiding this comment.
This looks good but this is my fork, the PR should go to the upstream 👀
saschanaz
reviewed
Aug 21, 2025
Owner
saschanaz
left a comment
saschanaz
left a comment
There was a problem hiding this comment.
This looks good but this is my fork, the PR should go to the upstream 👀
Author
|
thanks, not sure why I ended up on your fork instead of upstream :-D Opened microsoft#2122 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See reference https://w3c.github.io/uievents/#event-type-input