Skip to content

Readd getset#188

Merged
saschagrunert merged 1 commit intomasterfrom
getset-proc-macro
Feb 14, 2020
Merged

Readd getset#188
saschagrunert merged 1 commit intomasterfrom
getset-proc-macro

Conversation

@saschagrunert
Copy link
Copy Markdown
Owner

No description provided.

@CreepySkeleton
Copy link
Copy Markdown

This is a bug in getset, as expected. I sent a fixing PR to them.

For now, you can just remove #[clap(crate_version!())] line, this is the default behavior.

@saschagrunert
Copy link
Copy Markdown
Owner Author

This is a bug in getset, as expected. I sent a fixing PR to them.

For now, you can just remove #[clap(crate_version!())] line, this is the default behavior.

Wow cool, thank you! :)

Signed-off-by: Sascha Grunert <sgrunert@suse.com>
@saschagrunert saschagrunert changed the title Readd getset to reproduce proc-macro crash Readd getset Feb 14, 2020
@saschagrunert saschagrunert marked this pull request as ready for review February 14, 2020 07:47
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 14, 2020

Codecov Report

Merging #188 into master will decrease coverage by 0.1%.
The diff coverage is 100%.

@@           Coverage Diff            @@
##           master    #188     +/-   ##
========================================
- Coverage      51%   50.9%   -0.2%     
========================================
  Files          23      23             
  Lines        1574    1548     -26     
========================================
- Hits          804     789     -15     
+ Misses        770     759     -11

@saschagrunert saschagrunert merged commit f30f5ef into master Feb 14, 2020
@saschagrunert saschagrunert deleted the getset-proc-macro branch February 14, 2020 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants