Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

com.github.sarxos.webcam.WebcamDiscoveryService - Discovery will not run - driver MyCompositeDriver does not support this feature #332

Closed
henriquem opened this issue Apr 16, 2015 · 9 comments

Comments

@henriquem
Copy link

When I replace webcam-capture-0.3.10-RC7.jar to 0.3.11-SNAPSHOT.jar
I noticed that changed something:

class MyCompositeDriver extends WebcamCompositeDriver {
    public MyCompositeDriver() {
        // add(new WebcamDefaultDriver()); // usb cam 
        add(new IpCamDriver()); // ipcam 
    }
}

In version webcam-capture-0.3.11-SNAPSHOT.jar occur this message:

INFO com.github.sarxos.webcam.WebcamDiscoveryService - Discovery will not run - driver MyCompositeDriver does not support this feature

I kept the version the driver web-ipcam: 0.3.10-RC7

@sarxos
Copy link
Owner

sarxos commented Apr 17, 2015

Hi @henriquem,

Well, this is rather because IpCamDriver does not support discovery. Discovery Service has been designed to detect cameras that has been connected/disconnected from the USB and therefore, in case of IP cameras, which are HTTP enabled, this feature does not make much sense imho (because it may scan cameras registry which is static), however if if you thing it should be enabled to notify about new cameras found the registry (not sure if you implemented such feature), I can enable it in SNAPSHOT.

@sarxos
Copy link
Owner

sarxos commented Apr 17, 2015

@henriquem, I just noticed out that you have also USB camera in composite driver. Didn't catch this earlier (coffee machine is broken, so you know, ehh), sorry.

I will add discovery support in composite :) It will scan all sub-drivers which are discovery enabled. Is it ok?

@kamenomagic
Copy link

I am in need of this feature--did it ever get implemented?

@sarxos
Copy link
Owner

sarxos commented Nov 3, 2017

@kamenomagic, I completely forgot to add this :(

@sarxos
Copy link
Owner

sarxos commented Nov 3, 2017

@kamenomagic, I just added this feature but I had no time to test it. Feel free to verify it and fix if I made some mistake :)

@sarxos
Copy link
Owner

sarxos commented Nov 3, 2017

I also released newest snapshot version 0.3.12-SNAPSHOT which contains this change.

@sarxos sarxos closed this as completed Nov 3, 2017
@kamenomagic
Copy link

Awesome! I will try it out and let you know/fix it (if I can!). Will the 0.3.12-SNAPSHOT appear on the maven repository? (I was using gradle for 0.3.11, I'm not sure how to get the 0.3.12-SNAPSHOT). Thanks for the quick turn around.

@sarxos
Copy link
Owner

sarxos commented Nov 3, 2017

@kamenomagic, this snapshot version is available from the Sonatype snapshot repository (as described on the project main page). To make it work you would have to add this repository into your Maven's POM file:

<repository>
	<id>Sonatype OSS Snapshot Repository</id>
	<url>http://oss.sonatype.org/content/repositories/snapshots</url>
</repository>

It can be added to Gradle as well, probably (since I do not use Gradle in any of my projects):

repositories {
  maven { url "http://oss.sonatype.org/content/repositories/snapshots" }
  mavenCentral()
}

Note: I'm not very familiar with Gradle and this snipped may be incorrect. Please verify it with some reliable Gradle source of information.

@kamenomagic
Copy link

That worked for the snapshot, and it looks like it's working as expected for discovery of webcams. Thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants