Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lockfile and fix backward compatibility #208

Merged
merged 4 commits into from
Mar 11, 2020
Merged

Conversation

techalchemy
Copy link
Member

  • VcsSupport classes need to be instantiated on pip<19.2
  • This provides backward compatibility
  • Use required global_tempdir_manager for managing pip temporary
    directories

Signed-off-by: Dan Ryan <[email protected]>
- Use required `global_tempdir_manager` for managing pip temporary
  directories

Signed-off-by: Dan Ryan <[email protected]>
- VcsSupport classes need to be instantiated on pip<19.2
- This provides backward compatibility

Signed-off-by: Dan Ryan <[email protected]>
@ghost
Copy link

ghost commented Mar 11, 2020

DeepCode's analysis on #5d3b07 found:

  • 0 critical issues. ⚠️ 0 warnings and 2 minor issues. ✔️ 0 issues were fixed.

💬 This comment has been generated by the DeepCode bot, installed by the owner of the repository. The DeepCode bot protects your repository by detecting and commenting on security vulnerabilities or other critical issues.


☺️ If you want to provide feedback on our bot, here is how to contact us.

@codecov
Copy link

codecov bot commented Mar 11, 2020

Codecov Report

Merging #208 into master will decrease coverage by 0.28%.
The diff coverage is 64.28%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #208      +/-   ##
=========================================
- Coverage   63.19%   62.9%   -0.29%     
=========================================
  Files          13      13              
  Lines        5507    5513       +6     
  Branches     1338    1336       -2     
=========================================
- Hits         3480    3468      -12     
- Misses       1577    1587      +10     
- Partials      450     458       +8
Impacted Files Coverage Δ
src/requirementslib/models/setup_info.py 66.79% <100%> (-1.06%) ⬇️
src/requirementslib/models/vcs.py 69.04% <25%> (-4.13%) ⬇️
src/requirementslib/models/dependencies.py 56.37% <71.42%> (+0.17%) ⬆️
src/requirementslib/models/utils.py 60.78% <0%> (-0.83%) ⬇️
src/requirementslib/models/requirements.py 61.51% <0%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad34828...5d3b070. Read the comment docs.

@techalchemy techalchemy merged commit efcd987 into master Mar 11, 2020
@techalchemy techalchemy deleted the update-lockfile branch March 11, 2020 13:57
techalchemy added a commit that referenced this pull request Mar 31, 2020
Update lockfile and fix backward compatibility
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant