Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing second parameter to vcs.update #63

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Missing second parameter to vcs.update #63

wants to merge 1 commit into from

Conversation

frostming
Copy link
Member

Testing case:

[[source]]
name = "pypi"
url = "https://pypi.org/simple"
verify_ssl = true

[packages]
requests = {git = "https://github.com/requests/requests", ref = "master"}

[dev-packages]

It is great that passa can resolve non-editable VCS deps. Iooking forward to replacing pip-tools.

@uranusjr
Copy link
Member

uranusjr commented Dec 7, 2018

Does the second argument always exist? We’ll need to make sure this works with older pip versions.

@frostming
Copy link
Member Author

@uranusjr Oh no i didn't check that, it turns out it was introduced in v18.1 😢

@pradyunsg
Copy link

Yea, pip's VCS support code has been getting cleaned up and improved lately.

@techalchemy
Copy link
Member

wait why are we still using this directly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants