Performance improvement when finding tasks in a subworkflow #425
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before a subworkflow would use an exception based approach to finding a task by id. When profiling an example multi-instance workflow this could result in ~1 million exceptions being thrown just so None could be returned. Fix is to just directly call get on
self.tasks
. For the example process this improves runtime by about 22% and results in ~3 million less function calls. Timings below are from spiff-arena's backend.Before:
After: