Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up script engine methods #388

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Conversation

essweine
Copy link
Contributor

@essweine essweine commented Feb 15, 2024

This PR

  • moves the implementation of the call_service method to the scripting environment (though the engine itself will retain the method with a deprecation warning through the next release)
  • remove the _execute and _evaluate methods in favor of just calling the environment directly.

This moves towards creating a clearer distinction between the how the script engine interacts with the workflow (which most people are likely to not need to extend) vs how exec and eval work (which people are likely to do), providing a unified extension mechanism (for most use cases).

@essweine essweine merged commit ae3ed3e into main Feb 15, 2024
5 checks passed
@essweine essweine deleted the improvement/script-engine-cleanup branch February 15, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants