Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement/task and spec relations #349

Merged
merged 3 commits into from
Sep 6, 2023

Conversation

essweine
Copy link
Contributor

This PR

  • adds attributes for storing inputs and outputs as spec names on task specs with properties for returning the objects
  • adds a tasks attribute to the workflow that allows access to tasks by id rather than traversing the tree
  • a little miscellaneous cleanup around serialization

The purpose of these changes is to make deserialization simpler (it's no longer necessary to reconnect all the task specs during deserialization, and tasks can be deserialized independently of constructing the task tree).

@essweine essweine marked this pull request as draft September 1, 2023 04:14
@essweine essweine marked this pull request as ready for review September 6, 2023 15:34
@essweine essweine merged commit 179d62c into main Sep 6, 2023
4 checks passed
@essweine essweine deleted the improvement/task-and-spec-relations branch September 6, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants