Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement/better subworkflow management #339

Merged
merged 7 commits into from
Jun 13, 2023

Conversation

essweine
Copy link
Contributor

@essweine essweine commented Jun 13, 2023

This PR splits adds a simple BpmnSubworkflow class that

  • keeps track of the task id that controls the subprocess
  • allows better navigation inside nested subprocesses
  • adds a depth property

The order of execution inside do_engine_steps has changed. Tasks are completed by subprocess, starting with those at the lowest depth. This allows do_engine_steps to refresh waiting tasks whenever all the available tasks in a subprocess are complete. This should make it more intuitive to use.

It also cleans up some methods in both Workflow and BpmnWorkflow, and removes some BPMN related attributes that have migrated into the base Workflow class.

@essweine essweine requested a review from jbirddog June 13, 2023 17:53
Copy link
Contributor

@burnettk burnettk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so there is a subworkflow.parent that returns a UUID, eh. is there any chance this could be renamed to parent_guid or parent_id or something for clarity? approving in either case.

@essweine essweine merged commit dbe41c8 into main Jun 13, 2023
@essweine essweine deleted the improvement/better-subworkflow-management branch June 13, 2023 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants