raise exceptions when MI input or output items already exist

sartography · Jul 28, 2023 · 282b9e0 · 282b9e0
1 parent 52d65df
commit 282b9e0
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/SpiffWorkflow/bpmn/specs/mixins/multiinstance_task.py b/SpiffWorkflow/bpmn/specs/mixins/multiinstance_task.py
@@ -130,8 +130,11 @@ def create_child(self, my_task, item, key_or_index=None):
         task_spec = my_task.workflow.spec.task_specs[self.task_spec]
         child = my_task._add_child(task_spec, TaskState.WAITING)
         child.triggered = True
-        child.data = deepcopy(my_task.data)
-        if self.input_item is not None:
+        if self.input_item is not None and self.input_item.bpmn_id in my_task.data:
+            raise WorkflowDataException(f'Multiinstance input item {self.input_item.bpmn_id} already exists.')
+        if self.output_item is not None and self.output_item.bpmn_id in my_task.data:
+            raise WorkflowDataException(f'Multiinstance output item {self.output_item.bpmn_id} already exists.')
+        if self.input_item is not None:                
             child.data[self.input_item.bpmn_id] = deepcopy(item)
         if key_or_index is not None:
             child.internal_data['key_or_index'] = key_or_index