Skip to content

Conversation

@m273d15
Copy link
Contributor

@m273d15 m273d15 commented Feb 18, 2020

Fix #830

I tested:

  • local execution
  • import and build in IntelliJ
  • import and build in Eclipse + launch config

@m273d15 m273d15 added Area: IntelliJ Issue affecting Saros for IntelliJ (Saros/I) Area: Infrastructure Issue affecting the infrastructure to build, test and deploy Saros and its documentation labels Feb 18, 2020
@m273d15 m273d15 requested review from stefaus and tobous February 18, 2020 13:00
Two jars with the same name lead
to a race-condition during a gradle
build with --parallel (which leads
to a failing build with a high
probability)
@m273d15
Copy link
Contributor Author

m273d15 commented Feb 18, 2020

This leads to a renamed saros.core.jar -> saros.core-plain.jar in the zip file.

Copy link
Member

@tobous tobous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Works for me when using runIde or building the zip and using it. For Eclipse, I only tried the run config.

I am not really sure how IntelliJ builds the classpath of the plugin. I couldn't find any meta information in the build zip stating the dependencies to the other jars or which jar is actually the plugin. So that probably has to be resolved dynamically, meaning the name of the core jar should not matter either way.

As a side note:
The plain jar (for Saros/I) still contains the old meta file stating the contained and exported JARs that are actually no longer present.

But for that to cause issues, a user would have to actively try replacing the core jar in their Eclipse installation with one extracted from the IntelliJ zip. So I don't think it really matters.

@m273d15
Copy link
Contributor Author

m273d15 commented Feb 18, 2020

The plain jar (for Saros/I) still contains the old meta file stating the contained and exported JARs that are actually no longer present.

True, we can think about providing a simple manifest (without the osgi stuff, just the name and version) that is created by gradle as we already do in the server and lsp build

@m273d15 m273d15 merged commit e257a06 into master Feb 18, 2020
@m273d15 m273d15 deleted the pr/build/intellij_jar branch February 18, 2020 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: Infrastructure Issue affecting the infrastructure to build, test and deploy Saros and its documentation Area: IntelliJ Issue affecting Saros for IntelliJ (Saros/I)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Saros/I build artifact contain duplicate library jars

3 participants